-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix celotool dockerfile #1088
Fix celotool dockerfile #1088
Conversation
How big is the docker file now? Can you try |
Looking at GCR "virtual size": :( |
Codecov Report
@@ Coverage Diff @@
## master #1088 +/- ##
=======================================
Coverage 66.45% 66.45%
=======================================
Files 256 256
Lines 7367 7367
Branches 491 427 -64
=======================================
Hits 4896 4896
- Misses 2379 2381 +2
+ Partials 92 90 -2
Continue to review full report at Codecov.
|
@ashishb this could be "fixed" if we used "npm builds" inspect of copying the mono repo... |
Yes, do a multi-stage build - https://github.com/celo-org/celo-monorepo/blob/master/dockerfiles/cli/Dockerfile#L48 |
Description
Adds
contractkit
&protocol
dependencies to the celotool dockerfile. Otherwise builds would fail, becausecontractkit
is required (andcontractkit
hasprotocol
as a dependency)Tested
Docker builds succeeded
Other changes
n/a
Related issues
n/a
Backwards compatibility
Yes