Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CIP8 signatures by DEK should be valid #7459

Closed
nambrot opened this issue Mar 17, 2021 · 0 comments · Fixed by #7467
Closed

CIP8 signatures by DEK should be valid #7459

nambrot opened this issue Mar 17, 2021 · 0 comments · Fixed by #7467
Labels
CAP Component: Storage Priority: P2 Major

Comments

@nambrot
Copy link
Contributor

nambrot commented Mar 17, 2021

Expected Behavior

DEK should be a valid signer

Current Behavior

Only authorized signers on Account.sol are valid
@nambrot nambrot mentioned this issue Mar 18, 2021
Merged
@mergify mergify bot closed this as completed in #7467 Mar 21, 2021
mergify bot pushed a commit that referenced this issue Mar 21, 2021
@nambrot
Allow DEK to be a CIP8 signer (#7467)
7e7a791 
### Description

This PR allows the DEK to be a CIP8 signer

### Other changes

- Set jest dependency resolution

### Tested

- Unit test 
- 
### Related issues

- Fixes #7459 

### Backwards compatibility

- Older clients might not recognize future clients using the DEK
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CAP Component: Storage Priority: P2 Major
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow DEK to be a CIP8 signer celo-org/celo-monorepo
1 participant
@nambrot