Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[P1] [Stretch] Verification 8-digit code #6097

Closed
i1skn opened this issue Dec 7, 2020 · 0 comments · Fixed by #6437
Closed

[P1] [Stretch] Verification 8-digit code #6097

i1skn opened this issue Dec 7, 2020 · 0 comments · Fixed by #6437
Assignees
@i1skn
Labels
Component: Attestations epic feature Feature requests Priority: P1 Critical wallet
Milestone
Milestone 8

Comments

@i1skn
Copy link
Contributor

i1skn commented Dec 7, 2020

What's important about this?

  • We can not launch it before ALL validators support https in their attestation services (currently at 95%)
  • We have seen that for some carriers, deliverability of SMS is better with 8-digit codes
  • 8-digit codes are a more familiar user experience
  • Opens the door for iOS Virtual Keyboard (autocomplete) reducing the need for user to leave the App

What is "done"?

  • Users can to verify using 8 digit codes

What's involved in doing this work?

  • Add authentication header to request o Valora side
  • Remove firebase Proxy for attestation requests
  • Ramping up (remove feature flag)
@i1skn i1skn added the wallet label Dec 7, 2020
@i1skn i1skn added this to the Milestone 8 milestone Dec 7, 2020
@i1skn i1skn added the epic label Dec 7, 2020
@i1skn i1skn changed the title [P1] Verification 8-digit code [P1] [Stretch] Verification 8-digit code Dec 7, 2020
@i1skn i1skn self-assigned this Dec 10, 2020
@i1skn i1skn mentioned this issue Jan 11, 2021
Merged
@mergify mergify bot closed this as completed in #6437 Jan 12, 2021
mergify bot pushed a commit that referenced this issue Jan 12, 2021
@i1skn
[Wallet] Enable 8 digit code verification and ignore attestation serv…
0a91ca1 
…ices below 1.1.0 (#6437)

### Description

Enable 8 digit code verification and ignore attestation services below 1.1.0 as they do not support 8 digit codes.

### Other changes

Force EOA address as a signer to provide signature for attestation services.

### Tested

Android manual input and auto-import using attestation service 1.2.0 on alfajores.

### Related issues

- Fixes #6097

### Backwards compatibility

Yes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@i1skn i1skn

Labels
Component: Attestations epic feature Feature requests Priority: P1 Critical wallet
Projects
None yet
Milestone
Milestone 8
2 participants
@nityas @i1skn