Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reserve contract should use Fixidity #1301

Closed
annakaz opened this issue Oct 10, 2019 · 0 comments
Closed

Reserve contract should use Fixidity #1301

annakaz opened this issue Oct 10, 2019 · 0 comments
Assignees
@annakaz @jfoutts-celo
Labels
audit good first issue Good for newcomers protocol All issues relating to protocol packages tech-debt

Comments

@annakaz
Copy link
Contributor

annakaz commented Oct 10, 2019 •
edited by mcortesi
Loading

Expected Behavior

Reserve contract uses Fixidity to handle fractions

Replace tobinTax for fixidity values

Current Behavior

Reserve contract uses integers
Other contracts like the Exchange contract do use Fixidity
@annakaz annakaz added tech-debt protocol All issues relating to protocol packages labels Oct 10, 2019
@annakaz annakaz self-assigned this Oct 10, 2019
@asaj asaj added the good first issue Good for newcomers label Oct 14, 2019
@asaj asaj added the audit label Nov 6, 2019
jfoutts-celo added a commit that referenced this issue Nov 19, 2019
@jfoutts-celo
Address #1301 without changing ABI. Is this an improvement?
8683f98
@jfoutts-celo jfoutts-celo mentioned this issue Nov 20, 2019
Merged
jfoutts-celo added a commit that referenced this issue Nov 21, 2019
@jfoutts-celo
Improvements from PR review. Decide "not fixing" is least bad option …
cbf8040 
…for #1301
@leojoy95 leojoy95 mentioned this issue May 13, 2022
Open
@snyk-bot snyk-bot mentioned this issue May 30, 2022
Open
@snyk-bot snyk-bot mentioned this issue Jul 27, 2022
Open
@snyk-bot snyk-bot mentioned this issue Sep 27, 2022
Open
This was referenced May 17, 2023
Open
Open
@snyk-bot snyk-bot mentioned this issue Jun 10, 2023
Open
@lili2311 lili2311 mentioned this issue Jul 20, 2023
Open
This was referenced Nov 26, 2023
Open
Open
@lili2311 lili2311 mentioned this issue Dec 23, 2023
Open
@lili2311 lili2311 mentioned this issue Feb 3, 2024
Open
@lili2311 lili2311 mentioned this issue Mar 25, 2024
Open
@lili2311 lili2311 mentioned this issue Apr 15, 2024
Open
@lili2311 lili2311 mentioned this issue May 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@annakaz annakaz

@jfoutts-celo jfoutts-celo

Labels
audit good first issue Good for newcomers protocol All issues relating to protocol packages tech-debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@asaj @annakaz @jfoutts-celo