Slashing for non-validators work

celo-org · Oct 13, 2024 · da9cdc7 · da9cdc7
1 parent 3410b9b
commit da9cdc7
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 3 deletions.
diff --git a/packages/protocol/contracts/governance/GovernanceSlasher.sol b/packages/protocol/contracts/governance/GovernanceSlasher.sol
@@ -130,9 +130,8 @@ contract GovernanceSlasher is
       electionIndices
     );
 
-    IValidators validators = getValidators();
-
     if (group != address(0)) {
+      IValidators validators = getValidators();
       validators.forceDeaffiliateIfValidator(account);
       validators.halveSlashingMultiplier(group);
     }

diff --git a/packages/protocol/test-sol/unit/governance/network/GovernanceSlasher.t.sol b/packages/protocol/test-sol/unit/governance/network/GovernanceSlasher.t.sol
@@ -134,11 +134,36 @@ contract GovernanceSlasherTest_slashL2_WhenL1 is GovernanceSlasherTest {
   }
 }
 
-contract GovernanceSlasherTest_slashL2_WhenL2 is GovernanceSlasherTest, L2MakerAbstract {
+// should work just like the deprecated version
+contract GovernanceSlasherTest_slashL2_WhenL2_WhenNotGroup is
+  GovernanceSlasherTest,
+  L2MakerAbstract
+{
+  address group = address(0);
+
   function setUp() public {
     super.setUp();
     _whenL2();
   }
 
   // only onwer or multisig can call
+
+  function test_ShouldDecrementCelo() public {
+    governanceSlasher.approveSlashing(validator, 1000);
+    governanceSlasher.slashL2(validator, group, lessers, greaters, indices);
+    assertEq(mockLockedGold.accountTotalLockedGold(validator), 4000);
+  }
+
+  function test_ShouldHaveSetTheApprovedSlashingToZero() public {
+    governanceSlasher.approveSlashing(validator, 1000);
+    governanceSlasher.slashL2(validator, group, lessers, greaters, indices);
+    assertEq(governanceSlasher.getApprovedSlashing(validator), 0);
+  }
+
+  function test_EmitsGovernanceSlashPerformedEvent() public {
+    governanceSlasher.approveSlashing(validator, 1000);
+    vm.expectEmit(true, true, true, true);
+    emit GovernanceSlashPerformed(validator, 1000);
+    governanceSlasher.slashL2(validator, group, lessers, greaters, indices);
+  }
 }