Skip to content

Commit

Permalink
[Wallet] Upgrade react-native-sms-retriever to fix multiple SMS impor…
Browse files Browse the repository at this point in the history
…ts (#6263)

### Description

Upgrading `react-native-sms-retriever` to avoid duplicating attestation codes when auto import SMSs on Android.

### Other changes

Update the issue link for the race-condition issue https://github.com/celo-org/celo-monorepo/issues/6262

### Tested

Android Device, verification flow

### Related issues

- Fixes #5657 & #5209

### Backwards compatibility

Yes
  • Loading branch information
i1skn authored Dec 22, 2020
1 parent 336d7cd commit d0ec73a
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion packages/mobile/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"@celo/network-utils": "1.0.0-dev",
"@celo/react-components": "1.0.0",
"@celo/react-native-fast-crypto": "^1.8.4",
"@celo/react-native-sms-retriever": "git+https://github.com/celo-org/react-native-sms-retriever#b88e502",
"@celo/react-native-sms-retriever": "git+https://github.com/celo-org/react-native-sms-retriever#11e078e",
"@celo/utils": "1.0.0-dev",
"@celo/wallet-rpc": "1.0.0-dev",
"@react-native-community/async-storage": "^1.9.0",
Expand Down
6 changes: 3 additions & 3 deletions packages/mobile/src/identity/verification.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -673,7 +673,7 @@ describe(doVerificationFlow, () => {
[select(verificationStateSelector), mockVerificationStateUnverified],
[call(getConnectedUnlockedAccount), mockAccount],
// TODO (i1skn): remove next two lines when
// https://github.com/celo-org/celo-labs/issues/578 is resolved
// https://github.com/celo-org/celo-monorepo/issues/6262 is resolved
[delay(5000), true],
[delay(10000), true],
[
Expand Down Expand Up @@ -730,7 +730,7 @@ describe(doVerificationFlow, () => {
[select(verificationStateSelector), mockVerificationStatePartlyVerified],
[call(getConnectedUnlockedAccount), mockAccount],
// TODO (i1skn): remove next two lines when
// https://github.com/celo-org/celo-labs/issues/578 is resolved
// https://github.com/celo-org/celo-monorepo/issues/6262 is resolved
[delay(5000), true],
[delay(10000), true],
[
Expand Down Expand Up @@ -834,7 +834,7 @@ describe(doVerificationFlow, () => {
],
[call(getConnectedUnlockedAccount), mockAccount],
// TODO (i1skn): remove next two lines when
// https://github.com/celo-org/celo-labs/issues/578 is resolved
// https://github.com/celo-org/celo-monorepo/issues/6262 is resolved
[delay(5000), true],
[delay(10000), true],
[
Expand Down
2 changes: 1 addition & 1 deletion packages/mobile/src/identity/verification.ts
Original file line number Diff line number Diff line change
Expand Up @@ -804,7 +804,7 @@ export function* revealAttestations(
isFeelessVerification
)
// TODO (i1skn): remove this clause when
// https://github.com/celo-org/celo-labs/issues/578 is resolved.
// https://github.com/celo-org/celo-monorepo/issues/6262 is resolved
// This sends messages with 5000ms delay on Android if reveals is successful
if (success && Platform.OS === 'android') {
Logger.debug(
Expand Down
4 changes: 2 additions & 2 deletions packages/react-components/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"test:watch": "export TZ=UTC && jest --watch"
},
"dependencies": {
"@celo/react-native-sms-retriever": "git+https://github.com/celo-org/react-native-sms-retriever#b88e502",
"@celo/react-native-sms-retriever": "git+https://github.com/celo-org/react-native-sms-retriever#11e078e",
"@celo/utils": "1.0.0-dev",
"hoist-non-react-statics": "^3.3.0",
"lodash": "^4.17.14",
Expand All @@ -40,4 +40,4 @@
"react": "*",
"react-native": "*"
}
}
}
4 changes: 2 additions & 2 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2372,9 +2372,9 @@
buffer "^5.0.8"
rfc4648 "^1.0.0"

"@celo/react-native-sms-retriever@git+https://github.com/celo-org/react-native-sms-retriever#b88e502":
"@celo/react-native-sms-retriever@git+https://github.com/celo-org/react-native-sms-retriever#11e078e":
version "1.0.3"
resolved "git+https://github.com/celo-org/react-native-sms-retriever#b88e502fcd5bab2b6b9a22f59829c3eb40e27780"
resolved "git+https://github.com/celo-org/react-native-sms-retriever#11e078e7631348d27bf7a0e8d0e172701ae30ea8"

"@celo/[email protected]":
version "0.1.0-beta3"
Expand Down

0 comments on commit d0ec73a

Please sign in to comment.