Always run the election after block finalization #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nambrot
approved these changes
Nov 24, 2019
|
End-to-end tests are broken in the monorepo due to celo-org/celo-monorepo#1838, merging anyway to unblock the integration deployment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a discrepancy between block proposal creation and block proposal verification. In the former, the block was finalized after the election was run, while in the latter, the block was finalized before the election was run. When block finalization affects the results of the election (as it sometimes will via rewards to voters), this would lead to proposals that would fail to be verified.
Tested
By running the end-to-end tests with 10 validators multiple times.
Other changes
Backwards compatibility
Not backwards compatible