Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skipping flaky tests #1848

Merged
merged 5 commits into from
Feb 18, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Extended timeline for e2e tests
  • Loading branch information
hbandura committed Feb 18, 2022
commit 2cfe6f70e6de9314cf0b75f4abadd76009dfb960
6 changes: 2 additions & 4 deletions e2e_test/e2e_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,6 @@ func TestRPCDynamicTxGasPriceWithBigFeeCap(t *testing.T) {
// to know the exactly gasPrice expent in a dynamic tx, depends on consuming the
// GasPriceMinimum contract
func TestRPCDynamicTxGasPriceWithState(t *testing.T) {
t.Skip() // Flaky (deadline exceeded)
ac := test.AccountConfig(3, 2)
gc, ec, err := test.BuildConfig(ac)
ec.TxLookupLimit = 0
Expand All @@ -250,7 +249,7 @@ func TestRPCDynamicTxGasPriceWithState(t *testing.T) {
network, shutdown, err := test.NewNetwork(ac, gc, ec)
require.NoError(t, err)
defer shutdown()
ctx, cancel := context.WithTimeout(context.Background(), time.Second*30)
ctx, cancel := context.WithTimeout(context.Background(), time.Second*90)
defer cancel()

accounts := test.Accounts(ac.DeveloperAccounts(), gc.ChainConfig())
Expand Down Expand Up @@ -300,15 +299,14 @@ func TestRPCDynamicTxGasPriceWithState(t *testing.T) {
// to know the exactly gasPrice expent in a dynamic tx, depends on consuming the
// GasPriceMinimum contract
func TestRPCDynamicTxGasPriceWithoutState(t *testing.T) {
t.Skip() // Flaky (deadline exceeded)
ac := test.AccountConfig(3, 2)
gc, ec, err := test.BuildConfig(ac)
ec.TrieDirtyCache = 5
require.NoError(t, err)
network, shutdown, err := test.NewNetwork(ac, gc, ec)
require.NoError(t, err)
defer shutdown()
ctx, cancel := context.WithTimeout(context.Background(), time.Second*30)
ctx, cancel := context.WithTimeout(context.Background(), time.Second*90)
defer cancel()

accounts := test.Accounts(ac.DeveloperAccounts(), gc.ChainConfig())
Expand Down