Paying fee in currency other than Celo should be feasible if you just have enough.

[37ng]

Description

Modified tx fee checks in state_transition and tx_pool.

Tested

Automated tests.

Related issues

• Fixes Paying fee in currency other than Celo should be feasible if you just have enough. #1663

Backwards compatibility

Requires HF because this changed how transaction validity is checked

[codecov]

Codecov Report

Merging #1664 (ff35883) into master (9d141cf) will decrease coverage by 0.02%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master    #1664      +/-   ##
==========================================
- Coverage   56.06%   56.04%   -0.03%     
==========================================
  Files         605      605              
  Lines       80261    80269       +8     
==========================================
- Hits        44999    44987      -12     
- Misses      31731    31753      +22     
+ Partials     3531     3529       -2     

Impacted Files	Coverage Δ
cmd/utils/flags.go	2.86% <0.00%> (-0.01%)	⬇️
core/state_transition.go	53.50% <0.00%> (-0.72%)	⬇️
core/tx_pool.go	74.41% <75.00%> (+0.26%)	⬆️
p2p/server.go	65.97% <75.00%> (+0.37%)	⬆️
light/txpool.go	44.53% <100.00%> (+0.21%)	⬆️
p2p/dial.go	87.00% <100.00%> (ø)
eth/downloader/statesync.go	63.70% <0.00%> (-3.48%)	⬇️
p2p/discover/table.go	80.46% <0.00%> (-2.34%)	⬇️
p2p/simulations/mocker.go	33.63% <0.00%> (-0.91%)	⬇️
trie/trie.go	83.40% <0.00%> (-0.86%)	⬇️
... and 9 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0390b45...ff35883. Read the comment docs.

[trianglesphere]

Needs to have a merge in from master, but looking almost done.

[trianglesphere]

lgtm