-
-
Notifications
You must be signed in to change notification settings - Fork 940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: allow users to disable broker heartbeats #1998
enhance: allow users to disable broker heartbeats #1998
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the change seems feasible, however, is it possible for you to add some additional tests for the change?
Hello, I took the liberty to add a test case for this change. However I'm failing to add to a pull request as I'm new to git and I get a permission denied pushing to smart-programmer branch. No clue how to do it. I however attached a patch file to add the change in t/unit/test_mixins.py. Would that test case be enough for the proposed change? (I somehow cannot upload .patch so used .txt instead) |
thanks for the test! you have to open a PR on smart-programmer:enhance/disable-heartbeat-no-timeout branch. if you can't do that we will add the test from your provided code! |
or you can open a full PR with your tests and this PR's changes as well! we wil make sure both will get contributors credit |
I've create a new PR #2016 with both the change and the test case. |
broker heartbeats clutter the logs console which prevents users from seeing important logs. this allows users to disable broker heartbeats if timeout isn't provided.
reference issue