fix #553 by handling Initial resize and OnSizeChanged #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| // Size is 0x0 when we are on a modeless Form which is minimized. | ||
| if (!Size.IsEmpty && managedCefBrowserAdapter != null) |
There was a problem hiding this comment.
I believe in a few rare cases that OnSizeChanged was being called even whilst disposal was happening, so we'll likely still need the managedCefBrowserAdapter != null check.
|
Looks promising, the basics seem to be working
Few minor tweaks and I think this can be merged 👍 |
sylvain-hamel
force-pushed
the
fix_553b
branch
from
03b0de2 to
b72f3b7
Compare
|
done |
amaitland
added a commit
that referenced
this pull request
Nov 19, 2014
fix #553 by handling Initial resize and OnSizeChanged
|
Thanks 👍 |
This was referenced Nov 20, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two things:
1st, After re-sizing sometimes the browser does not react correctly. Changed from handling/forcing
OnPaintto handlingOnSizeChanged.2nd, #553 : The line added to
CefSharp.WinForms.Example\BrowserForm.cscauses the bug. The call toResize()insideIWebBrowserInternal.OnInitializedfixes it.