Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CefSharp.Offscreen, CefSharp.Offscreen.Example projects. #604

Merged
merged 6 commits into from
Nov 18, 2014

Conversation

jankurianski
Copy link
Member

Please run CefSharp.Offscreen.Example project to test this out (it is a Console application which takes a screenshot of the Google homepage).

I have ensured everything works in Debug/Release and x86/x64 mode, however I am unsure about the nuget packages as I don't know how to build them (and was hoping someone else could tell me if it works 😉).

Addresses issues #577, #518 (sort of; about printing, but screenshots may be acceptable), #462.

@jankurianski
Copy link
Member Author

Oh dear, adding the new projects has made AppVeyor angry. Anything I can do to fix that?

@jornh
Copy link
Contributor

jornh commented Nov 14, 2014

It says Failed — AppVeyor was unable to build non-mergeable pull request so apparently some sort of merge conflict - so make sure you are based on latest master

But it's not the end of the world. It's what we have them nets for ... 😄

@jankurianski
Copy link
Member Author

Ahh, thanks @jornh ... looks like I just missed out on 4b27600 from master

@amaitland
Copy link
Member

@jankurianski Fantastic! Thanks 👍

I have ensured everything works in Debug/Release and x86/x64 mode, however I am unsure about the nuget packages as I don't know how to build them (and was hoping someone else could tell me if it works 😉).

No problem, I can sort the nuget packages out (unless @jornh beats me to it 😄)

@amaitland amaitland added this to the 37.0.0 milestone Nov 14, 2014
@amaitland amaitland merged commit 8a0a34a into cefsharp:master Nov 18, 2014
@numbersint numbersint deleted the feature/offscreen-render branch December 22, 2014 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants