Upgrade to Cef 2062 with JSB #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…will need to be fixed.
…iptObjectWrapper Not working yet as having some c++ include issues
Add [Falgs] attribute as TransitionType can have multiple values Import values from cef_transition_type_t (cef_types.h) Rename some of the values (slightly friendlier names)
… to both which are slightly confusing (and don't provide any benefit). So simplify by setting SetIsLoading(true) on LoadStart and SetIsLoading(false) on LoadEnd. Then only set NavState in ClientAdapter::OnLoadingStateChange
amaitland
added a commit
that referenced
this pull request
Nov 11, 2014
Upgrade to Cef 2062 with JSB
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch should hopefully be ready for merging into
masterso final period of stabilization can commence.