Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Cef 1750 #492

Merged
merged 32 commits into from
Oct 3, 2014
Merged

Upgrade to Cef 1750 #492

merged 32 commits into from
Oct 3, 2014

Conversation

amaitland
Copy link
Member

  • Merge in changes from @peters
  • Remove DevToolsUrl
  • Remove unnecessary entries in CefSharp.Native.props
  • Update cef.redist references for WinForms and WPF examples

@amaitland
Copy link
Member Author

Based on PR #484
Few additional changes required to cleanup the Example projects

@amaitland
Copy link
Member Author

There are still a few build warnings that need to be addressed.

@peters
Copy link
Contributor

peters commented Sep 26, 2014

@amaitland Did you publish CefSharp.Wpf to staging ?

No joy :(

image

@jornh
Copy link
Contributor

jornh commented Sep 26, 2014

@peters, no Alex didn't push because my bad with not giving him push right for CefSharp.Common and CefSharp.Wpf on staging. Fixed now!

Only for https://staging.nuget.org/packages/CefSharp.WinForms/ we need the help from our benevolent leader @perlun - he's currently the only one with those rights there ... And when it's ready for prime time we again need @perlun at https://www.nuget.org/packages/CefSharp.Common/ the others I can tick off for @amaitland

Other than that nice to see good progress towards 33 👍 I guess there will be a bit of house keeping chores with the README.md, update of issues roadmap etc.?

@amaitland
Copy link
Member Author

@peters I'll push the other packages to staging shortly

@jornh At what point do you think we merge these changes? As for the housekeeping, I'm happy to help out updating the relevant docs and issues

@amaitland amaitland added the cef3 label Sep 28, 2014
@amaitland amaitland added this to the 33.0.0-pre2 milestone Sep 28, 2014
@amaitland
Copy link
Member Author

I've fixed the compiler performance warnings and one xml comment

@peters
Copy link
Contributor

peters commented Sep 29, 2014

@amaitland 33 👍

@amaitland
Copy link
Member Author

I've pushed a WinForms version to staging as well

https://staging.nuget.org/packages/CefSharp.WinForms/33.0.0-pre2

@amaitland
Copy link
Member Author

@jornh Can you think of any final pieces required before we merge this into master?

@jornh
Copy link
Contributor

jornh commented Sep 30, 2014

Nope, just make sure the NuGets are built with VS2012 and I think we are good!

Got any PRs or issues you think are important before pack, push, tag, move of issues that won't be closed to the non-pre milestone, copy of ChangeLog to Releases, update of README.md?

@perlun can you think of anything missing?

@jornh
Copy link
Contributor

jornh commented Sep 30, 2014

Huh? First minimalistic commit in a long time with amaitland@c542825 and I make appveyor barf saying it can't find staging.nuget.org?

Should we btw push CEF to NuGet proper and get rid of the staging reference?

@amaitland
Copy link
Member Author

@jornh I think that's just unfortunate timing! lol The Release build was successful.

I'd like someone to double check the packages before pushing to Nuget proper, make sure I haven't overlooked anything.

@amaitland
Copy link
Member Author

I think it's probably important to include DevTools in the next release, it's been stripped out of this commit as DevToolsUrl no longer exists.

Once this is sorted, I'll create a PR from this commit amaitland@2008b3d

@amaitland
Copy link
Member Author

Looking at the PR queue in detail, I'd like to get #412 and #471 sorted and merged, then release -pre3

@jornh jornh mentioned this pull request Oct 1, 2014
@jornh
Copy link
Contributor

jornh commented Oct 1, 2014

So far it's looking 👍 as seen from here, builds and runs the WinForms + Wpf Examples just fine (as expected 😄).

Looking fwd to cef.* packages without the -pre
cefsharp wpf example
`

@amaitland
Copy link
Member Author

http://www.ro.me/ actually works now!!! Whoop!

@jornh Pushing packages to staging now 😄

@amaitland
Copy link
Member Author

Uploaded! 😄

@amaitland
Copy link
Member Author

I've just added my first draft of a build script for CefSharp3, it's just a modified version from cef-binary. It will build both x86 and x64 in Release mode and generate nupkg files.

@jornh
Copy link
Contributor

jornh commented Oct 2, 2014

Sweet! amaitland@7dac850 just behaved as expected with the new training wheel free cef-binary NuGets. And I saw cef.sdk has both VS2012 and VS2013 libs, though I only tested with VS2013. So I think it's safe to push those to www.NuGet.org proper now.

Then I guess the CefSharp repo doesn't need NuGet.config in the root folder any more?

@amaitland
Copy link
Member Author

Guess we can get rid of NuGet.config, though it comes in handy for building your own packages and referencing them locally. So maybe just comment out the staging reference?

@jornh
Copy link
Contributor

jornh commented Oct 3, 2014

I just wanted to de-clutter the root folder a bit but you might have a point.

I'll merge this one now, then we can figure out the next steps elsewhere, maybe in #496

jornh added a commit that referenced this pull request Oct 3, 2014
@jornh jornh merged commit 12f9c29 into cefsharp:master Oct 3, 2014
@amaitland amaitland deleted the upgrade/1750 branch October 3, 2014 05:30
@amaitland
Copy link
Member Author

To de-clutter the root folder perhaps we can delete nunit and old directories? Thoughts?

@jornh
Copy link
Contributor

jornh commented Oct 3, 2014

Yes, I've been looking at those too. Maybe they contain something valuable for inspiration of xUnit tests - if we ever get more of that going. Let's wait a bit with de clutter and focus on 33 😄

@amaitland
Copy link
Member Author

Sounds like a plan 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants