-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Cef 1750 #492
Upgrade to Cef 1750 #492
Conversation
amaitland
commented
Sep 26, 2014
- Merge in changes from @peters
- Remove DevToolsUrl
- Remove unnecessary entries in CefSharp.Native.props
- Update cef.redist references for WinForms and WPF examples
…ve been nuked from CEF
Based on PR #484 |
There are still a few build warnings that need to be addressed. |
@amaitland Did you publish No joy :( |
@peters, no Alex didn't push because my bad with not giving him push right for Only for https://staging.nuget.org/packages/CefSharp.WinForms/ we need the help from our benevolent leader @perlun - he's currently the only one with those rights there ... And when it's ready for prime time we again need @perlun at https://www.nuget.org/packages/CefSharp.Common/ the others I can tick off for @amaitland Other than that nice to see good progress towards |
I've fixed the compiler performance warnings and one xml comment |
@amaitland 33 👍 |
I've pushed a https://staging.nuget.org/packages/CefSharp.WinForms/33.0.0-pre2 |
@jornh Can you think of any final pieces required before we merge this into |
Nope, just make sure the NuGets are built with VS2012 and I think we are good! Got any PRs or issues you think are important before pack, push, tag, move of issues that won't be closed to the non-pre milestone, copy of ChangeLog to Releases, update of @perlun can you think of anything missing? |
Huh? First minimalistic commit in a long time with amaitland@c542825 and I make appveyor barf saying it can't find Should we btw push CEF to NuGet proper and get rid of the staging reference? |
@jornh I think that's just unfortunate timing! lol The I'd like someone to double check the packages before pushing to |
I think it's probably important to include Once this is sorted, I'll create a PR from this commit amaitland@2008b3d |
http://www.ro.me/ actually works now!!! Whoop! @jornh Pushing packages to staging now 😄 |
Uploaded! 😄 |
…rently only has vs2013 target enabled)
…t (no need to open VS to build cefsharp3 now)
I've just added my first draft of a build script for |
Sweet! amaitland@7dac850 just behaved as expected with the new training wheel free Then I guess the |
Guess we can get rid of |
I just wanted to de-clutter the root folder a bit but you might have a point. I'll merge this one now, then we can figure out the next steps elsewhere, maybe in #496 |
To de-clutter the root folder perhaps we can delete |
Yes, I've been looking at those too. Maybe they contain something valuable for inspiration of xUnit tests - if we ever get more of that going. Let's wait a bit with de clutter and focus on 33 😄 |
Sounds like a plan 😄 |