Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DevToolsUrl Property #440

Merged
merged 3 commits into from
Aug 22, 2014
Merged

Add DevToolsUrl Property #440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d3237a0
Add DevToolsUrl property for temporary use until upgrade to Cef 1738
amaitland Aug 5, 2014
5e7e8b6
Merge remote-tracking branch 'remotes/upstream/master' into feature/a…
amaitland Aug 21, 2014
4fb72c9
Fix incorrect version number in comment
amaitland Aug 21, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions CefSharp.WinForms/ChromiumWebBrowser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,12 +243,17 @@ void IWebBrowserInternal.ShowDevTools()
{
// TODO: Do something about this one.
var devToolsUrl = managedCefBrowserAdapter.DevToolsUrl;
throw new NotImplementedException();
throw new NotImplementedException("Implement when Cef upgraded to 1750.");
}

void IWebBrowserInternal.CloseDevTools()
{
throw new NotImplementedException();
throw new NotImplementedException("Implement when Cef upgraded to 1750.");
}

public string DevToolsUrl
{
get { return managedCefBrowserAdapter.DevToolsUrl; }
}

public void Stop()
Expand Down
9 changes: 7 additions & 2 deletions CefSharp.Wpf/ChromiumWebBrowser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1037,12 +1037,17 @@ void IWebBrowserInternal.ShowDevTools()
{
// TODO: Do something about this one.
var devToolsUrl = managedCefBrowserAdapter.DevToolsUrl;
throw new NotImplementedException();
throw new NotImplementedException("Implement when Cef upgraded to 1750.");
}

void IWebBrowserInternal.CloseDevTools()
{
throw new NotImplementedException();
throw new NotImplementedException("Implement when Cef upgraded to 1750.");
}

public string DevToolsUrl
{
get { return managedCefBrowserAdapter.DevToolsUrl; }
}

void IWebBrowserInternal.OnFrameLoadStart(string url, bool isMainFrame)
Expand Down