Exposing flushcookie api. #313
Conversation
|
Reverting the timestamp because I ate to many 🍪 and it was flat out wrong. Need to see how we are going to accurately return the creation parameter when there is no set in .NET cookie class. (PS let me know if you want me to nuke the revert history) |
|
Sorry guys didn't create a topic branch for this fix, but here is a fix for #213 I also fixed a focus bug, mouseenter on the popup should change focus. |
|
Needed to add the mouse leave event too to make sure we release the mouse. |
brock8503
changed the title
| dpiTransform = new ScaleTransform( | ||
| 1 / matrix.M11, | ||
| 1 / matrix.M22 | ||
| ); |
There was a problem hiding this comment.
The last parenthesis should be aligned with dpiTransform, IMHO.
|
Also, I don't like to mix totally unrelated stuff (cookie handling) and DPI fixes into one single PR. 😄 Could you split it please? |
brock8503
changed the title
|
Does this mean we can close this one now? |
|
@brock8503 Are you able to merge in changes from master? |
|
Created PR #399 to progress getting this PR merged. |
Expose Flush Cookie API based on #313
|
Closed with #399 |
Been spending lots of time with the cookie API and notice we don't have this API exposed .
Put together
b5319b0for it.I modeled this after the VisitAllCookies API design.
More more more cookies 🍪 🍪 🍪
Also noticed we are not setting the creation time of the cookies in the visit API , pulling that information out of the struct and adding to the .net cookies in
63f13a4.Cookie time 🍪