Explicit implement internal interface #302
Conversation
|
any news on this one ? |
|
Same problem with this one. Needs a merge of master so it can be auto-merged. |
|
@jornh im done also added my changes to the win form portion. ready for review / merge |
|
@jornh What do you think about making this PR next in line to be merged? @JanEggers Any chance you can merge in master again? Apologies for having to do it twice! As stated above I'd like to get this resolved ASAP 😄 |
|
I agree - go ahead! Tightening the API up like this before getting out of beta potentially affects many people |
jornh
changed the title
| @@ -6,9 +6,11 @@ public interface IWebBrowserInternal : IWebBrowser | |||
| { | |||
| IDictionary<string, object> BoundObjects { get; } | |||
|
|
|||
| //TODO: shouldnt this be part of IWebBrowser | |||
There was a problem hiding this comment.
Once this PR is merged, I'd like to get some more API cleanup done, moving these to IWebBrowser is on that list.
There was a problem hiding this comment.
Also ShowDevTools and CloseDevTools should probably be moved to IWebBrowser as well. I'm thinking in the short term we move them as it's a minor change, and update down the track when we have a clearer picture of what's happening with DevTools in general.
|
@amaitland: its up to date |
|
@JanEggers Thank you! "Merge pull request" button has returned 😄 |
|
I've looked over it twice now and everything looks in order 👍 @jornh Mind running a pair of eyes over this when you get a second? |
|
Will do that after work/tonight @amaitland - also good work on getting those other PRs refreshed etc. lets On Wednesday, May 21, 2014, amaitland [email protected] wrote:
|
|
Just looking at I only took a few samples though trusting you guys already did a stellar job. I'd say merge away @amaitland! |
Explicit implement internal interface
|
Sorry @amaitland, couldn't help myself... 😜 😃 |
No description provided.