Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Use experimental cef.sdk and cef.redist packages #2204

Closed
wants to merge 1 commit into from

Conversation

perlun
Copy link
Member

@perlun perlun commented Dec 3, 2017

These packages are custom-built by me, and includes proprietary codecs. The legal status of using these packages is questionable, so use them at your own risk.

They were built using this build script, and these Chromium flags:

set CEF_USE_GN=1
set GN_DEFINES=is_official_build=true proprietary_codecs=true ffmpeg_branding=Chrome
set GYP_DEFINES=buildtype=Official
set GYP_MSVS_VERSION=2015
set CEF_ARCHIVE_FORMAT=tar.bz2
set DEPOT_TOOLS_UPDATE=0

python ..\automate\automate-git.py --download-dir=. --depot-tools-dir=..\depot_tools --minimal-distrib --client-distrib --branch=3202 --force-build --no-debug-build

See cefsharp/cef-binary#62 for the CEF version being used here.

This is a temporary workaround for #1479. Once CEF 63 has landed, we should make an official CefSharp version based on that; this is definitely just for the time being. You may run into legal trouble if you use these packages, especially in certain jurisdictions.

The unofficial packages are here: https://www.myget.org/feed/Packages/perlun

@perlun perlun self-assigned this Dec 3, 2017
@perlun perlun force-pushed the perlun/proprietary-codecs-experiment branch from 2dafcdc to 25428ed Compare December 3, 2017 22:27
These packages are custom-built by me, and includes proprietary codecs. The legal status of using these packages is questionable, so use them at your own risk.
@perlun perlun force-pushed the perlun/proprietary-codecs-experiment branch from 25428ed to 7900b8d Compare December 3, 2017 22:46
@mitchcapper
Copy link
Contributor

It seeps the depency of CEfSharp.WPF on CefSharp.Common is not quite correct:
Attempting to resolve dependencies for package 'CefSharp.Wpf.62.0.0-proprietary-codecs' with DependencyBehavior 'Lowest'
Unable to find a version of 'CefSharp.Common' that is compatible with 'CefSharp.Wpf 62.0.0-proprietary-codecs constraint: CefSharp.Common (= 62.0.0-CI2368)'.

Not a big deal installing both packages manually still works.

@amaitland
Copy link
Member

I see you published these to Nuget.org, which has my name against the packages, I wish to make it very clear that I had nothing to do with providing packages that contain proprietary codes and won't take any responsibility for any legal liability.

@perlun
Copy link
Member Author

perlun commented Dec 3, 2017

@amaitland

I see you published these to Nuget.org, which has my name against the packages

Moving this discussion to private email, because of the nature of this.

@mitchcapper

It seeps the depency of CEfSharp.WPF on CefSharp.Common is not quite correct:

Thanks, I noted that also while doing a test upgrade in a project - published new packages with fixed dependencies. These packages have now been moved to a non-CefSharp-related MyGet feed, since we want to make it clear that these packages are not officially affiliated with or endorsed by the project, or people involved in it.

perlun added a commit to cefsharp/CefSharp.MinimalExample that referenced this pull request Dec 3, 2017
This PR illustrates how you can take advantage of the changes done in cefsharp/CefSharp#2204, bearing with potential legal consequences.
@cefsharp cefsharp deleted a comment from amaitland Dec 4, 2017
@vwmberry95
Copy link
Contributor

I've been watching this closely for the past week or so, and for those of us that have legal H264 licensing, thank you! I've had a hell of a time getting proprietary codecs enabled with the stable release of CefSharp on v57.

@perlun
Copy link
Member Author

perlun commented Dec 7, 2017

I've been watching this closely for the past week or so, and for those of us that have legal H264 licensing, thank you!

You're welcome. One thing worth checking out is that ffmpeg_branding=Chrome might mean that the Chromium code is compiled with GPL licensed libraries included. These can not be combined with non-GPL libraries without very serious legal consequences.

I haven't found the conclusive list of compiler flags being used for ffmpeg with this setting; if anyone else finds it, please paste the link here so we can better analyze this.

@mitchcapper
Copy link
Contributor

@perlun calling avutil_configuration (https://ffmpeg.org/doxygen/1.2/group__lavu__ver.html) should return the exact compile args for the library.

@perlun
Copy link
Member Author

perlun commented Jan 6, 2018

Closing this for now, it's gotten stale anyway. Once #1479 has landed, we can all shout for joy. 🎉 Probably a few months away though.

@perlun perlun closed this Jan 6, 2018
@perlun perlun deleted the perlun/proprietary-codecs-experiment branch January 6, 2018 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants