-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] Use experimental cef.sdk and cef.redist packages #2204
Conversation
2dafcdc
to
25428ed
Compare
These packages are custom-built by me, and includes proprietary codecs. The legal status of using these packages is questionable, so use them at your own risk.
25428ed
to
7900b8d
Compare
It seeps the depency of CEfSharp.WPF on CefSharp.Common is not quite correct: Not a big deal installing both packages manually still works. |
I see you published these to Nuget.org, which has my name against the packages, I wish to make it very clear that I had nothing to do with providing packages that contain proprietary codes and won't take any responsibility for any legal liability. |
Moving this discussion to private email, because of the nature of this.
|
This PR illustrates how you can take advantage of the changes done in cefsharp/CefSharp#2204, bearing with potential legal consequences.
I've been watching this closely for the past week or so, and for those of us that have legal H264 licensing, thank you! I've had a hell of a time getting proprietary codecs enabled with the stable release of CefSharp on v57. |
You're welcome. One thing worth checking out is that I haven't found the conclusive list of compiler flags being used for |
@perlun calling avutil_configuration (https://ffmpeg.org/doxygen/1.2/group__lavu__ver.html) should return the exact compile args for the library. |
Closing this for now, it's gotten stale anyway. Once #1479 has landed, we can all shout for joy. 🎉 Probably a few months away though. |
These packages are custom-built by me, and includes proprietary codecs. The legal status of using these packages is questionable, so use them at your own risk.
They were built using this build script, and these Chromium flags:
See cefsharp/cef-binary#62 for the CEF version being used here.
This is a temporary workaround for #1479. Once CEF 63 has landed, we should make an official CefSharp version based on that; this is definitely just for the time being. You may run into legal trouble if you use these packages, especially in certain jurisdictions.
The unofficial packages are here: https://www.myget.org/feed/Packages/perlun