Allow calling managed methods from objects bound with RegisterAsyncJsObject that return arrays #1979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to V8 context enter
merceyz
reviewed
Mar 8, 2017
| callback->Fail(argList->GetString(3)); | ||
| } | ||
| //dispose | ||
| delete callback; |
There was a problem hiding this comment.
If it somehow fails this wont be called, you should place it inside the finally block
There was a problem hiding this comment.
Didn't change that bit, but will do it.
|
Need a better description for this |
joaompneves
changed the title
|
This PR is redundant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When using RegisterAsyncJsObject to bind a C# object it was not possible to call managed methods that return arrays, due to a crash in the browser sub process.
Details:
CefV8Value::CreateArray in DeserializeV8Object expects prior call to Enter of the V8 context, and without that call, CreateArray returned null.
Fix:
Call V8 context Enter in OnProcessMessageReceived from CefAppUnmanagedWrapper.