Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IBrowserSettings.CaretBrowsing - was removed from CEF API #1967

Merged
merged 1 commit into from
Mar 13, 2017

Conversation

mtschoen
Copy link

CEF commit SHA-1 was cdcdfa99913a01f3617a0d25a2e2f2ed145987bd.

I was building against the latest CEF and noticed encountered the following error:
C2039: 'caret_browsing': is not a member of 'CefStructBase' CefSharp.Core c:\code\cefsharp\cefsharp\cefsharp.core\BrowserSettings.h 220

All l had to do was remove that property from the I/BrowserSettings type, and everything worked fine.

@amaitland amaitland changed the title Remove CaretBrowsing from IBrowserSettings to match latest CEF master Remove CaretBrowsing from IBrowserSettings Mar 5, 2017
@amaitland
Copy link
Member

CEF commit SHA-1 was cdcdfa99913a01f3617a0d25a2e2f2ed145987bd.

Thanks for taking the time to submit a PR 👍 CefSharp doesn't target CEF Master, the next version will be based off the 2987 branch. I haven't checked to see if this PR is relevant for that branch, will leave open for now.

@amaitland amaitland added this to the 57.0.0 milestone Mar 13, 2017
@amaitland amaitland merged commit 24841e7 into cefsharp:master Mar 13, 2017
@amaitland amaitland changed the title Remove CaretBrowsing from IBrowserSettings Remove IBrowserSettings.CaretBrowsing - was removed from CEF Mar 29, 2017
@amaitland amaitland changed the title Remove IBrowserSettings.CaretBrowsing - was removed from CEF Remove IBrowserSettings.CaretBrowsing - was removed from CEF API Mar 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants