Skip to content

Commit

Permalink
Net Core - ManagePackageVersionsCentrally exclude chromiumembeddedfra…
Browse files Browse the repository at this point in the history
…mework.runtime packages

- When Nuget packages are managed centrally the build will break when no RuntimeIdentifier is specified
  as the .targets file includes <PackageReference/> entries for the chromiumembeddedframework.runtime packages.
  For now when ManagePackageVersionsCentrally exclude the <ItemGroup />

Issue #4362
  • Loading branch information
amaitland committed Mar 7, 2023
1 parent 4f6fdf8 commit edf99b5
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion NuGet/PackageReference/CefSharp.Common.NETCore.targets
Original file line number Diff line number Diff line change
Expand Up @@ -140,10 +140,12 @@
</ItemGroup>
</When>
<Otherwise>
<ItemGroup>
<ItemGroup Condition="'$(ManagePackageVersionsCentrally)' != 'true'">
<PackageReference Include="chromiumembeddedframework.runtime.win-x64" Version="111.0.11" />
<PackageReference Include="chromiumembeddedframework.runtime.win-x86" Version="111.0.11" />
<PackageReference Include="chromiumembeddedframework.runtime.win-arm64" Version="111.0.11" />
</ItemGroup>
<ItemGroup>
<Content Include="@(CefRuntimeWin32Locales)">
<Link>runtimes\win-x86\native\locales\%(RecursiveDir)%(FileName)%(Extension)</Link>
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
Expand Down

0 comments on commit edf99b5

Please sign in to comment.