[cleanup] Remove now-unused compareHeights util

+ clean up mock rowHeightUtils as well
cee-chen · Oct 25, 2021 · 1e3ded2 · 1e3ded2
1 parent 22aed7a
commit 1e3ded2
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 13 deletions.
diff --git a/src/components/datagrid/__mocks__/row_height_utils.ts b/src/components/datagrid/__mocks__/row_height_utils.ts
@@ -23,12 +23,7 @@ export const mockRowHeightUtils = ({
   isAutoHeight: jest.fn(() => false),
   setRowHeight: jest.fn(),
   getRowHeight: jest.fn(() => 32),
-  getFont: jest.fn(() => null),
   getComputedCellStyles: jest.fn(() => {}),
-  compareHeights: jest.fn(
-    (currentRowHeight: number, cachedRowHeight: number) =>
-      currentRowHeight === cachedRowHeight
-  ),
   getCalculatedHeight: jest.fn(
     (heightOption: EuiDataGridRowHeightOption, defaultHeight: number) => {
       if (typeof heightOption === 'object') {

diff --git a/src/components/datagrid/body/__snapshots__/data_grid_cell.test.tsx.snap b/src/components/datagrid/body/__snapshots__/data_grid_cell.test.tsx.snap
@@ -11,11 +11,9 @@ exports[`EuiDataGridCell renders 1`] = `
   rowHeightUtils={
     Object {
       "clearHeightsCache": [MockFunction],
-      "compareHeights": [MockFunction],
       "computeStylesForGridCell": [MockFunction],
       "getCalculatedHeight": [MockFunction],
       "getComputedCellStyles": [MockFunction],
-      "getFont": [MockFunction],
       "getRowHeight": [MockFunction],
       "getStylesForCell": [MockFunction],
       "isAutoHeight": [MockFunction],
@@ -60,11 +58,9 @@ exports[`EuiDataGridCell renders 1`] = `
           rowHeightUtils={
             Object {
               "clearHeightsCache": [MockFunction],
-              "compareHeights": [MockFunction],
               "computeStylesForGridCell": [MockFunction],
               "getCalculatedHeight": [MockFunction],
               "getComputedCellStyles": [MockFunction],
-              "getFont": [MockFunction],
               "getRowHeight": [MockFunction],
               "getStylesForCell": [MockFunction],
               "isAutoHeight": [MockFunction],

diff --git a/src/components/datagrid/row_height_utils.ts b/src/components/datagrid/row_height_utils.ts
@@ -89,10 +89,6 @@ export class RowHeightUtils {
     return 0;
   }
 
-  compareHeights(currentRowHeight: number, cachedRowHeight: number) {
-    return currentRowHeight === cachedRowHeight;
-  }
-
   resetGrid() {
     this.grid?.resetAfterRowIndex(this.lastUpdatedRow);
     this.lastUpdatedRow = Infinity;