Verify TPM attestation certificate trustworthiness #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdewater
force-pushed
the
tpm-cert-verification
branch
from
2d1dc41 to
5f64d45
Compare
…e for known manufacturer Found via https://github.com/abergs/fido2-net-lib/blob/b44db521ee487f7d29b2de34f8c6b57f1bc9700e/Src/Fido2/AttestationFormat/Tpm.cs#L506-L540 https://www.trustedcomputinggroup.org/wp-content/uploads/Credential_Profile_EK_V2.0_R14_published.pdf specifies how and what exactly must be encoded.
…icate trustworthiness Hat-tip to Alex Seigler for pointing me to https://docs.microsoft.com/en-us/windows-server/security/guarded-fabric-shielded-vm/guarded-fabric-install-trusted-tpm-root-certificates Downloaded version of TrustedTpm.cab has "22-May-2019" as last changelog entry.
bdewater
force-pushed
the
tpm-cert-verification
branch
from
5f64d45 to
13ed764
Compare
|
For the record, this branch doesn't pass the tpm FIDO tests because of the extra verification. I guess it we'll need the |
|
Given this is part of #66 we are planning to merge into |
grzuy
reviewed
Oct 31, 2019
10 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar in spirit to #208 but the MDS does not have any TPM root certificates last time I checked, so we'll need to bring our own.
Huge thanks to the maintainers of the .NET library that pointed me in the right direction 🙌
See commit messages for more details.