feat: verify packed x5c start/end dates #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grzuy
changed the title
bdewater
reviewed
Apr 7, 2019
| end | ||
| end | ||
|
|
||
| # TODO: Reevaluate this check |
There was a problem hiding this comment.
Good call - certificates containing RSA keys should be valid too.
| def certificate_in_use?(certificate) | ||
| now = Time.now | ||
|
|
||
| certificate.not_before < now && now < certificate.not_after |
There was a problem hiding this comment.
This doesn't add real security since any certificate is trusted. A more thorough solution that includes this check as well would be to verify using a certificate trust story (like in Android Safetynet), but then #66 becomes required again to do this properly.
There was a problem hiding this comment.
I agree this is not thorough.
Just a step in that direction.
|
Thank you for reviewing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.