Trade fee #28
Merged
Trade fee #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esemi
force-pushed
the
trade_fee
branch
3 times, most recently
from
47be6c1 to
4173438
Compare
|
тестов добавил |
esemi
force-pushed
the
trade_fee
branch
3 times, most recently
from
ec91787 to
c341af7
Compare
|
Нашёл проблему в отображении маленькой комиссии на итоговом отчёте по сделкам |
|
@cdump пофиксил округление в отчёте (визуальная проблема была) билды упали ибо set-env таки запретили, пофиксил в соседнем МР |
|
Обновил пример отчёта в ридми |
esemi
force-pushed
the
trade_fee
branch
2 times, most recently
from
70afa59 to
8209773
Compare
|
@cdump пинг) |
cdump
requested changes
Nov 22, 2020
|
|
||
| analyze_trades_fifo_testdata = [ | ||
| # trades: [(Date, Symbol, Quantity, Price)] | ||
| # expect_trades: (N, Symbol, Quantity, Total, Profit) |
There was a problem hiding this comment.
WIP: подумать, не сломается ли #8 - тест на подобный баг
esemi
force-pushed
the
trade_fee
branch
4 times, most recently
from
f28d704 to
fda2f79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Сделал учёт комиссий в расчёте профита по сделкам
Всё в рублях, всё по курсам на соответствующие даты
Осталось:
покрыть тестами prepare_trades_report раз уж у нас там такая важная калькуляцияобновить пример отчёта тулы в ридмиотображать в отчёте больше двух знаков после точки для комиссий