Rust: Use Typed State Mutability #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe we can use https://docs.rs/alloy-json-abi/0.8.0/alloy_json_abi/enum.StateMutability.html |
|
Ah! absolutely. Don't want to create a new enum either |
cdump
requested changes
Sep 5, 2024
|
Merged, thanks. Next version will be 0.5.0 as this PR breaks the 0.4.x API. |
|
Make sense to bump the major version. Thank you! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add an enum
StateMutabilityinto the rust part and change the return type offunction_state_mutabilityfrom&'static strto this enum.Using enum for such determined return values reduces the chance of typo mistake when consuming the return value from evmole