Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix perf test link sending #2446

Merged
merged 1 commit into from
Feb 7, 2025
Merged

fix perf test link sending #2446

merged 1 commit into from
Feb 7, 2025

Conversation

sastels
Copy link
Collaborator

@sastels sastels commented Feb 7, 2025 •
edited
Loading

Summary | Résumé

The template we're using to send file links in the perf test has a ((var)) but our perf test code uses application_file. We could change the template, but other code could be using it. Safer to change the perf test.

Related Issues | Cartes liées

Test instructions | Instructions pour tester la modification

Perf tests should run with no errors (after we get the annual limits issue fixed)

Release Instructions | Instructions pour le déploiement

None.

Reviewer checklist | Liste de vérification du réviseur

  • This PR does not break existing functionality.
  • This PR does not violate GCNotify's privacy policies.
  • This PR does not raise new security concerns. Refer to our GC Notify Risk Register document on our Google drive.
  • This PR does not significantly alter performance.
  • Additional required documentation resulting of these changes is covered (such as the README, setup instructions, a related ADR or the technical documentation).

⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.

sastels
sastels commented Feb 7, 2025
View reviewed changes
tests-perf/locust/locust-notifications.py
@@ -3,16 +3,16 @@
"""
# flake8: noqa

from tests_smoke.smoke.common import job_line, rows_to_csv # type: ignore
from locust import HttpUser, constant_pacing, task
from dotenv import load_dotenv
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vscode did this when saving the file for reasons?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe as we are now using ruff?

@sastels sastels marked this pull request as ready for review February 7, 2025 18:34
@sastels sastels requested a review from jimleroyer February 7, 2025 18:35
jimleroyer
jimleroyer approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@jimleroyer jimleroyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sastels sastels merged commit c636d81 into main Feb 7, 2025
5 checks passed
@sastels sastels deleted the fix-perf-test-file-attachments branch February 7, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimleroyer jimleroyer jimleroyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sastels @jimleroyer