checkpoint

cdouglas · Dec 10, 2024 · 67a540b · 67a540b
1 parent ebfef93
commit 67a540b
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 1 deletion.
diff --git a/core/src/main/java/org/apache/iceberg/TableMetadataParser.java b/core/src/main/java/org/apache/iceberg/TableMetadataParser.java
@@ -32,6 +32,7 @@
 import java.util.Map;
 import java.util.zip.GZIPInputStream;
 import java.util.zip.GZIPOutputStream;
+import org.apache.commons.io.IOUtils;
 import org.apache.iceberg.TableMetadata.MetadataLogEntry;
 import org.apache.iceberg.TableMetadata.SnapshotLogEntry;
 import org.apache.iceberg.exceptions.RuntimeIOException;
@@ -134,6 +135,23 @@ public static void internalWrite(
     }
   }
 
+  public static void internalWrite(TableMetadata metadata, OutputStream out, boolean close) {
+    OutputStreamWriter writer = null;
+    try {
+      writer = new OutputStreamWriter(out);
+      JsonGenerator generator = JsonUtil.factory().createGenerator(writer);
+      generator.useDefaultPrettyPrinter();
+      toJson(metadata, generator);
+      generator.flush();
+    } catch (IOException e) {
+      throw new RuntimeIOException(e, "Failed to write json to stream");
+    } finally {
+      if (close) {
+        IOUtils.closeQuietly(writer);
+      }
+    }
+  }
+
   public static String getFileExtension(String codecName) {
     return getFileExtension(Codec.fromName(codecName));
   }

diff --git a/core/src/main/java/org/apache/iceberg/io/FileIOCatalog.java b/core/src/main/java/org/apache/iceberg/io/FileIOCatalog.java
@@ -353,6 +353,7 @@ public void commitTransaction(List<TableCommit> commits) {
       if (newMetadata.changes().isEmpty()) {
         continue;
       }
+      // !#! HERE
       final String newLocation = ops.writeUpdateMetadata(false, newMetadata);
       newCatalog.updateTable(tableId, newLocation);
     }

diff --git a/core/src/test/java/org/apache/iceberg/io/TestCatalogFile.java b/core/src/test/java/org/apache/iceberg/io/TestCatalogFile.java
@@ -20,6 +20,7 @@
 
 import static org.assertj.core.api.Assertions.assertThat;
 
+import java.io.ByteArrayOutputStream;
 import java.io.OutputStream;
 import java.util.Collections;
 import java.util.Map;
@@ -61,5 +62,7 @@ public void testCatalogNamespace() {
   }
 
   @Test
-  public void testSerDe() {}
+  public void testSerDe() {
+    ByteArrayOutputStream bos = new ByteArrayOutputStream();
+  }
 }