feat: support all jsii programming languages #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a required `--language` switch to cdk-import which allows specifying the target programming language to generate code in. This uses jsii-srcmak (similar to CDKtf and CDK8s) to generate files that can be included in projects. Resolves #34 BREAKING CHANGE: cdk-import now requires --language to be specified.
|
@hoegertn would love your review on this PR. |
Chriscbr
suggested changes
Sep 30, 2021
added 2 commits
October 3, 2021 14:22
Not sure I love the idea of defaulting to TypeScript. As a standalone tool, cdk-import will likely be used in CDK apps, and not in construct libraries and I don't think TypeScript it necessarily a reasonable default. Maybe in the future, we can include the language specification in |
hoegertn
approved these changes
Oct 3, 2021
|
@Chriscbr can you take another look? |
Chriscbr
approved these changes
Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a required
--languageswitch to cdk-import which allows specifying the target programming languageto generate code in. This uses jsii-srcmak (similar to CDKtf and CDK8s) to generate files that can be
included in projects.
Resolves #34
BREAKING CHANGE: a
--languageswitch is now required and can have one of these values:typescript,java,csharp,pythonorgolang.