feat: everything is a construct #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eli Polonsky <[email protected]>
Signed-off-by: Eli Polonsky <[email protected]>
rix0rrr
approved these changes
May 25, 2022
cdk8s-automation
pushed a commit
that referenced
this pull request
May 25, 2022
Currently, imported resources are not treated as constructs. We didn't initially implement them this way because there was no need, and it makes the API slightly more awkward. Lately, we've been adding more and more of those, and a use case for them being constructs has risen, when those resources are being used for constructing actual managed resources. This PR makes it so all imported resources (and selected as well) are constructs, and thus have stable id's we can use. Even though this hurts API ergonomics a little bit, its worth it for the simplicity and flexibility it gives us. This is also in-line with how the AWS CDK treats imported resources, and in general, having to pass scopes and id's to classes in a construct library is a well known practice. BREAKING CHANGE: You must now pass a `scope` and `id` to imported and selected resources (cherry picked from commit 24d9f61) Signed-off-by: Eli Polonsky <[email protected]>
cdk8s-automation
pushed a commit
that referenced
this pull request
May 25, 2022
Currently, imported resources are not treated as constructs. We didn't initially implement them this way because there was no need, and it makes the API slightly more awkward. Lately, we've been adding more and more of those, and a use case for them being constructs has risen, when those resources are being used for constructing actual managed resources. This PR makes it so all imported resources (and selected as well) are constructs, and thus have stable id's we can use. Even though this hurts API ergonomics a little bit, its worth it for the simplicity and flexibility it gives us. This is also in-line with how the AWS CDK treats imported resources, and in general, having to pass scopes and id's to classes in a construct library is a well known practice. BREAKING CHANGE: You must now pass a `scope` and `id` to imported and selected resources (cherry picked from commit 24d9f61) Signed-off-by: Eli Polonsky <[email protected]>
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
mergify bot
pushed a commit
that referenced
this pull request
May 25, 2022
# Backport This will backport the following commits from `k8s-24/main` to `k8s-22/main`: - [feat: everything is a construct (#747)](#747) ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)
mergify bot
pushed a commit
that referenced
this pull request
May 25, 2022
# Backport This will backport the following commits from `k8s-24/main` to `k8s-23/main`: - [feat: everything is a construct (#747)](#747) ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, imported resources are not treated as constructs. We didn't initially implement them this way because there was no need, and it makes the API slightly more awkward.
Lately, we've been adding more and more of those, and a use case for them being constructs has risen, when those resources are being used for constructing actual managed resources.
This PR makes it so all imported resources (and selected as well) are constructs, and thus have stable id's we can use.
Even though this hurts API ergonomics a little bit, its worth it for the simplicity and flexibility it gives us. This is also in-line with how the AWS CDK treats imported resources, and in general, having to pass scopes and id's to classes in a construct library is a well known practice.
BREAKING CHANGE: You must now pass a
scopeandidto imported and selected resources