-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ticket events #180
Add ticket events #180
Conversation
0e59c30
to
ac8289c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, it mostly looks good to me.
I left some comment, I think the schema might be a bit too specific in some places, and we could get along with a list of labels for many things like group
, type
, milestone
and priority
. It might be worth adding a few words to explain why we want include those fields as separate ones.
c642e5e
to
6335848
Compare
According to the schemas in this PR, the subject.content object has a required 'uri' field, but the examples provided in the PR don't have that. @sbrennan4 , please validate the examples towards the corresponding json schemas. |
Thanks @e-backmark-ericsson - yeah, that's the reason for CI job failure |
@sbrennan4 you'll need to add a few words to the custom dictionary as well:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a minor request for updates, but I don't consider it important enough to hinder the approval. Such NITs could be cleaned up at a later stage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks good!
It would be nice if you included @e-backmark-ericsson suggestions but we can also do those as follow-up.
@sbrennan4 could you please sign all the commits in the PR so this becomes mergeable? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I signed the commits following the directions from the CI check, which is satisfied with the string "Signed-off-by:". Seems the merge check wants a GPG or SSH key. Might want to update the CI check accordingly if possible.
5b07d1d
to
85b03ac
Compare
Signed-off-by: Sean Brennan <[email protected]>
85b03ac
to
fb9dda6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sbrennan4 - great addition to CDEvents!
Changes
Add ticket events.
Design doc: https://hackmd.io/9eTiXHu6RfedSuSwUMGTLw?both
Implements #164
Submitter Checklist
As the author of this PR, please check off the items in this checklist: