fix(buildApiResponse): response content type #318
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included
Notes
text/plain
content type. It appears the issue was around commit 7fc30f9 and introduced inv4.3.0
unfortunately the unit tests wouldn't catch a simple parameter rename issue but an end-2-end would, we're reviewing how we can catch this in the future...mistaken, a consuming function unit testbuildResponse
helps cover this gap, test addedHow to test
Coverage and basic unit test check
$ yarn
$ yarn test
Local development run
$ yarn
$ yarn start:dev
./data/example.js
file to include... and confirm that is the response type returned in the
log
andbrowser
Example
...
Updates issue/story
ongoing