Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cli): flatten file arch #316

Merged
merged 2 commits into from
Jan 15, 2024
Merged

refactor(cli): flatten file arch #316

merged 2 commits into from
Jan 15, 2024

Conversation

cdcabrera
Copy link
Owner

What's included

  • refactor(cli): flatten file arch
  • build(docker): nodejs 18 move

Notes

  • flattening the cli directory structure, using naming to make distinction
  • update docker 16 alpine to 18 in anticipation of the move to make nodejs 20 the minimum version later this year

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm tests come back clean

...

Example

...

Updates issue/story

ongoing

@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2024

Codecov Report

Merging #316 (7303e1c) into main (200a639) will increase coverage by 0.00%.
The diff coverage is 92.85%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #316   +/-   ##
=======================================
  Coverage   79.57%   79.58%           
=======================================
  Files           6        7    +1     
  Lines         284      289    +5     
  Branches       96       96           
=======================================
+ Hits          226      230    +4     
- Misses         52       53    +1     
  Partials        6        6           
Files Coverage Δ
src/apidocConfig.js 100.00% <ø> (ø)
src/apidocParse.js 79.24% <100.00%> (ø)
src/buildApiResponse.js 76.22% <100.00%> (ø)
src/global.js 87.75% <ø> (ø)
src/index.js 69.69% <100.00%> (ø)
src/logger.js 80.00% <100.00%> (ø)
src/apidocBuild.js 87.50% <75.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 200a639...7303e1c. Read the comment docs.

@cdcabrera cdcabrera merged commit dc0e158 into main Jan 15, 2024
4 checks passed
cdcabrera added a commit that referenced this pull request Jan 15, 2024
@cdcabrera cdcabrera deleted the 202401-perf branch January 25, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants