Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): on update restart server #210

Merged
merged 1 commit into from
Jan 29, 2023
Merged

fix(cli): on update restart server #210

merged 1 commit into from
Jan 29, 2023

Conversation

cdcabrera
Copy link
Owner

@cdcabrera cdcabrera commented Jan 29, 2023

What's included

  • fix(cli): on update restart server

Notes

  • refresh issue around Express restarting gracefully. apparently this issue has been around for a bit. it was masked by restarts from other tooling.
    • dev run with $ yarn start:dev remained unaffected

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm tests come back clean

Interactive local run

  1. update the NPM packages with $ yarn
  2. $ yarn start
  3. navigate towards the default http://localhost:8000/hello/world
    • then edit [project]/data/example.js apidoc comments as you normally would
    • observe the cli rebuild
    • hit refresh in the browser, and then confirm the response corresponds to your manual edit in [project]/data/example.js

Example

...

Updates issue/story

ongoing
related #19

* build, httpTerminator
* index, server shut down, restart
@cdcabrera cdcabrera added the bug Something isn't working label Jan 29, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #210 (0f338f9) into main (a7c9446) will decrease coverage by 0.19%.
The diff coverage is 53.84%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #210      +/-   ##
==========================================
- Coverage   71.98%   71.79%   -0.19%     
==========================================
  Files           5        5              
  Lines         232      234       +2     
  Branches       85       85              
==========================================
+ Hits          167      168       +1     
- Misses         56       57       +1     
  Partials        9        9              
Impacted Files Coverage Δ
src/index.js 77.77% <53.84%> (-1.30%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7c9446...0f338f9. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants