Skip to content
This repository has been archived by the owner on Apr 30, 2024. It is now read-only.

Fix card width issue on mobile #906

Closed
wants to merge 84 commits into from
Closed

Conversation

clasick
Copy link
Contributor

@clasick clasick commented Jun 29, 2021

Fixes

Fixes #860 by @frappelatte28

Description

Cards are broken on lower resolution devices (like mobile). Issue was that the cards were having a static width set. This needed to be changed to max-width for lower resolution devices to scale it down but also not have ridiculously large card components on higher resolutions.

Tests

Run Storybook and navigate to Cards section. Turn on Web Responsive Mode and choose a mobile device and scroll around, observe that the cards are within the width of the image and nothing is broken.

Screenshots

Before fix, as reported by @frappelatte28 :

card-width-issue
After this change:

card-width-issue-fix

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@clasick clasick requested review from a team as code owners June 29, 2021 13:46
@clasick clasick requested review from nimishbongale and hugosolar and removed request for a team June 29, 2021 13:46
@brylie brylie self-assigned this Jul 13, 2021
@github-actions
Copy link

Stale pull request message

@brylie
Copy link
Contributor

brylie commented Sep 13, 2021

@clasick, thank you so much for the contribution.

I'm going to close this pull request without merging the changes since it is stale and there are unresolved conflicts. Please feel free to re-open the pull request if you have the time to continue the task 😃

@brylie brylie closed this Sep 13, 2021
@clasick
Copy link
Contributor Author

clasick commented Sep 14, 2021

@clasick, thank you so much for the contribution.

I'm going to close this pull request without merging the changes since it is stale and there are unresolved conflicts. Please feel free to re-open the pull request if you have the time to continue the task

@brylie Thanks for the update! If I'm understanding correctly, the only task left is to resolve the merge conflicts?

@brylie
Copy link
Contributor

brylie commented Sep 15, 2021

@clasick yes. Please resolve conflicts and re-open the pull request :-)

@clasick
Copy link
Contributor Author

clasick commented Sep 19, 2021

@brylie Fixed the conflicts. Could you reopen this pull request so I can update it? It only shows me an option to create a new one since this is closed as of now.

@brylie brylie reopened this Sep 20, 2021
@brylie
Copy link
Contributor

brylie commented Sep 20, 2021

PR is open :-)

@clasick
Copy link
Contributor Author

clasick commented Sep 20, 2021

@brylie Thanks! Looks like the merges are reflected in the PR now.

On a side note, merging was done through a rebase. I see 15 files are shown as changed in the PR diff except only one is an actual change (it's showing the diff between when this PR was created and not what is the current state of the branch). I hope this would won't pollute commit history once it's merged?

@brylie
Copy link
Contributor

brylie commented Sep 21, 2021

@clasick I'd like to hold off from merging this pull request until the project restructuring is complete: #905

@MuluhGodson MuluhGodson mentioned this pull request Oct 12, 2021
10 tasks
@brylie
Copy link
Contributor

brylie commented Oct 13, 2021

@clasick, we have recently refactored the project structure. Would you mind applying your fix against the new project structure?

@brylie brylie marked this pull request as draft October 13, 2021 09:19
@Akpjunior94 Akpjunior94 mentioned this pull request Oct 13, 2021
1 task
@brylie brylie closed this Oct 13, 2021
@brylie
Copy link
Contributor

brylie commented Oct 13, 2021

This change was merged into main with attribution given to @clasick

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Cards are not responsive in mobile view.
4 participants