-
Notifications
You must be signed in to change notification settings - Fork 129
Conversation
Correct branch name in all packages' CI workflows
Fix Storybook WSOD with some dependency updates
…rs/add-dhruvkb docs: add dhruvkb as a contributor for code, mentoring
…rs/add-chidexebere docs: add chidexebere as a contributor for code
Stale pull request message |
@clasick, thank you so much for the contribution. I'm going to close this pull request without merging the changes since it is stale and there are unresolved conflicts. Please feel free to re-open the pull request if you have the time to continue the task 😃 |
@brylie Thanks for the update! If I'm understanding correctly, the only task left is to resolve the merge conflicts? |
@clasick yes. Please resolve conflicts and re-open the pull request :-) |
@brylie Fixed the conflicts. Could you reopen this pull request so I can update it? It only shows me an option to create a new one since this is closed as of now. |
PR is open :-) |
@brylie Thanks! Looks like the merges are reflected in the PR now. On a side note, merging was done through a rebase. I see 15 files are shown as changed in the PR diff except only one is an actual change (it's showing the diff between when this PR was created and not what is the current state of the branch). I hope this would won't pollute commit history once it's merged? |
@clasick, we have recently refactored the project structure. Would you mind applying your fix against the new project structure? |
This change was merged into main with attribution given to @clasick |
Fixes
Fixes #860 by @frappelatte28
Description
Cards are broken on lower resolution devices (like mobile). Issue was that the cards were having a static width set. This needed to be changed to max-width for lower resolution devices to scale it down but also not have ridiculously large card components on higher resolutions.
Tests
Run Storybook and navigate to Cards section. Turn on Web Responsive Mode and choose a mobile device and scroll around, observe that the cards are within the width of the image and nothing is broken.
Screenshots
Before fix, as reported by @frappelatte28 :
After this change:
Checklist
Update index.md
).main
ormaster
).visible errors.
Developer Certificate of Origin
Developer Certificate of Origin