vmsdk (python): refine get_quote output format #22
Conversation
intelzhongjie
force-pushed
the
dev-quote
branch
9 times, most recently
from
7bc033b to
7980bbd
Compare
intelzhongjie
changed the title
| print(f'{indent}{type(self).__name__}:') | ||
| if fmt == Quote.QUOTE_OUT_FORMAT_HUMAN: | ||
| i = indent + " " | ||
| print(f'{i}Header Version: {self.ver}') |
There was a problem hiding this comment.
Please use LOG instead of print
There was a problem hiding this comment.
Changed. Please review the updated version. Thanks!
|
|
||
| class Quote(ABC): | ||
| """ | ||
| Quote abstract class (interface) | ||
| """ | ||
|
|
||
| QUOTE_OUT_FORMAT_RAW = "raw" | ||
| QUOTE_OUT_FORMAT_HUMAN = "human" | ||
|
|
||
| @abstractmethod | ||
| def get_header(self) -> QuoteHeader: |
There was a problem hiding this comment.
Is this applicable for TPM quote?
There was a problem hiding this comment.
Sorry for the confusing. Please let me clarify:
They are not defined by TPM. These format are used for dump() that is defined in our code.
I think the definition can be shared by TPM Quote dump and TDX Qute dump.
There was a problem hiding this comment.
As discussion, I have removed these literal definitions from this top-level base class to avoid confusion.
Please review the updated version. Thanks!
intelzhongjie
force-pushed
the
dev-quote
branch
8 times, most recently
from
b21d5fb to
560e38e
Compare
Signed-off-by: zhongjie <[email protected]>
intelzhongjie
force-pushed
the
dev-quote
branch
from
560e38e to
901e713
Compare
| return True | ||
| return False | ||
|
|
||
|
|
||
| class Tpm2Quote(Quote): |
There was a problem hiding this comment.
Let move Tpm2Quote to a new directory
No description provided.