Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify MPI data types to old standard #175

Merged
merged 4 commits into from
Mar 18, 2024
Merged

Conversation

cburstedde
Copy link
Owner

@cburstedde cburstedde commented Mar 14, 2024

We had a couple data types that came in after MPI 1.3. Some were not consistently represented in all their aspects. We removed sc_MPI_SIGNED_CHAR and sc_MPI_DOUBLE_INT. We redefined INT8 to BYTE and UNSIGNED_LONG_LONG to LONG_LONG. Hopefully this works with very old MPI installations.

Update: to be very strict, we delete the MPI types for unsigned long long and int8_t. They are too new.
Update: reinstate MPI_DOUBLE_INT, it is very old.

We had a couple data types that came in after MPI 1.3.
Some were not consistently represented in all their aspects.
We removed sc_MPI_SIGNED_CHAR and sc_MPI_DOUBLE_INT.
We redefined INT8 to BYTE and UNSIGNED_LONG_LONG to LONG_LONG.
@cburstedde
Copy link
Owner Author

This might be the last change for version 2.8.6. Any comment @hannesbrandt @tim-griesbach ?

@cburstedde cburstedde mentioned this pull request Mar 18, 2024
@cburstedde
Copy link
Owner Author

Thanks, about to merge and release if there are no further comments.

@hannesbrandt
Copy link
Collaborator

Thanks, about to merge and release if there are no further comments.

I saw that MPI_DOUBLE_INT is part of MPI standard 1.3. Do we want to remove sc_MPI_DOUBLE_INT nonetheless?

@cburstedde
Copy link
Owner Author

Thanks, about to merge and release if there are no further comments.

I saw that MPI_DOUBLE_INT is part of MPI standard 1.3. Do we want to remove sc_MPI_DOUBLE_INT nonetheless?

It's a weird thing, 12 bytes and all. But for the sake of backwards compatbility, letting it live and reducing the diff as much as possible would be a good thing. Would you be able to do this?

@cburstedde
Copy link
Owner Author

Thanks, about to merge and release if there are no further comments.

I saw that MPI_DOUBLE_INT is part of MPI standard 1.3. Do we want to remove sc_MPI_DOUBLE_INT nonetheless?

It's a weird thing, 12 bytes and all. But for the sake of backwards compatbility, letting it live and reducing the diff as much as possible would be a good thing. Would you be able to do this?

Don't worry, I'm on it.

@cburstedde cburstedde merged commit 6ea37fc into develop Mar 18, 2024
34 checks passed
@cburstedde cburstedde deleted the feature-mpi-types branch March 18, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants