-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify MPI data types to old standard #175
Conversation
We had a couple data types that came in after MPI 1.3. Some were not consistently represented in all their aspects. We removed sc_MPI_SIGNED_CHAR and sc_MPI_DOUBLE_INT. We redefined INT8 to BYTE and UNSIGNED_LONG_LONG to LONG_LONG.
This might be the last change for version 2.8.6. Any comment @hannesbrandt @tim-griesbach ? |
Thanks, about to merge and release if there are no further comments. |
I saw that MPI_DOUBLE_INT is part of MPI standard 1.3. Do we want to remove sc_MPI_DOUBLE_INT nonetheless? |
It's a weird thing, 12 bytes and all. But for the sake of backwards compatbility, letting it live and reducing the diff as much as possible would be a good thing. Would you be able to do this? |
Don't worry, I'm on it. |
We had a couple data types that came in after MPI 1.3. Some were not consistently represented in all their aspects. We removed sc_MPI_SIGNED_CHAR and sc_MPI_DOUBLE_INT. We redefined INT8 to BYTE and UNSIGNED_LONG_LONG to LONG_LONG. Hopefully this works with very old MPI installations.
Update: to be very strict, we delete the MPI types for unsigned long long and int8_t. They are too new.
Update: reinstate MPI_DOUBLE_INT, it is very old.