Add custom transform functions. Would solve #10. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fredrikw I like your idea of passing a callable, that would bring more flexibility, although I'm not sure the support of format strings is even necessary at that point. It would be easier (and probably clearer) to just support functions. |
cbouy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an example implementation of how to solve #10. The demo notebook contains code that use features in RDKit 2021.3 that I commented out since I haven't upgraded yet. Please feel free to uncomment those and rerun the notebook :-)
While implementing I realised that there is a choice to make if one should format or style first. I opted to apply the format after the styling code...