Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor / Communicator creation and updates #1707

Merged
merged 24 commits into from
Jun 26, 2024
Merged

Refactor / Communicator creation and updates #1707

merged 24 commits into from
Jun 26, 2024

Conversation

RodriSanchez1
Copy link
Collaborator

@RodriSanchez1 RodriSanchez1 commented Jun 7, 2024 •
edited
Loading

On this PR:

  • A new function verifyAndUpsertCommunicator() was created. This function checks if the logged user has his own communicator, and if is not creates one. After that, the communicator is upserted. Note that this function is just for upsert the local store.
  • Implement the upsertApiCommunicator() when is necessary

close #1701

@RodriSanchez1
Refactor upserApiCommunicator, return a Promise on action call
8fb86b9
@RodriSanchez1
Add catch block after upsertApiCommunicator on changeDefaultBoard
3d557ec
@RodriSanchez1
Use upsertApiCommunicator
e2cf08b
@RodriSanchez1
Remove unused createCommunicator flag varables
2998cb0
@RodriSanchez1
Create verifyAndUpsertCommunicator
58771e7
@RodriSanchez1
Add async definition to thunk actions
c29e70d
@RodriSanchez1
Refactor CommunicatorDialogContainer to use verifyAndUpsertCommunicat…
780adfd 
…or for updating boards and root board
@RodriSanchez1
Refactor CommunicatorToolbar.container.js and use verifyAndUpsertComm…
cf3cdae 
…unicator for updating communicators
@RodriSanchez1
Refactor ImportContainer to use verifyAndUpsertCommunicator for updat…
6dfd439 
…ing communicators and boards
@RodriSanchez1
Change communicator by default on verifyAndUpsertCommunicator
1967e72
@RodriSanchez1
Shallow copy of boards and defaultBoardsIncluded on communicator crea…
c80b7f9 
…tion
@RodriSanchez1
Change console.log for console.error
c2d8fb3
@RodriSanchez1
Add await on try catch block
22e874b
@RodriSanchez1
Refactor verifyAndUpsertCommunicator
2aec38f
@RodriSanchez1
Use verifyAndUpsertCommunicator on changeDefaultBoard
cc9814b
@RodriSanchez1
Refactor Board container functions to use verifyAndUpsertContainer
837a054
@RodriSanchez1
Add upserApiCommunicator un editCommunicatorTitle
00f56a0
@RodriSanchez1
Use verifyAndUpsertCommunicator on CommunicatorDialog container funct…
c584104 
…ions
@RodriSanchez1
Use verifyAndUpsertCommunicator on addBoardsToCommunicator on import …
4e0d235 
…container
@RodriSanchez1
Remove log
be5f699
@RodriSanchez1 RodriSanchez1 added this to the 1.34.0 milestone Jun 19, 2024
@RodriSanchez1 RodriSanchez1 marked this pull request as ready for review June 19, 2024 23:15
@RodriSanchez1 RodriSanchez1 requested a review from tomivm June 19, 2024 23:15
@RodriSanchez1 RodriSanchez1 changed the title Refactor/implementUpsertApiCommunicator Refactor / Communicator creation and updates Jun 19, 2024
tomivm
tomivm approved these changes Jun 20, 2024
View reviewed changes
Copy link
Collaborator

@tomivm tomivm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!! it's more legible and easy to understand now. We have to be careful while merging the rest of the PR because of the modifications in updateApiObjects and updateApiObjectsNoChild. We have to do an exhaustive test to avoid unexpected behaviors 🚀

@RodriSanchez1 RodriSanchez1 merged commit cd351ad into cboard-org:master Jun 26, 2024
5 checks passed
@RodriSanchez1 RodriSanchez1 deleted the refactor/implementUpsertApiCommunicator branch June 26, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomivm tomivm tomivm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.34.0
Development

Successfully merging this pull request may close these issues.

Implement the upsertApiCommunicator action
2 participants
@RodriSanchez1 @tomivm