Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Clear Arasaac db #1535

Merged

Conversation

RodriSanchez1
Copy link
Collaborator

@RodriSanchez1 RodriSanchez1 commented Jul 11, 2023

On this PR:

  • Generat a static URL in the case that the tile was selected from the idb and is no internet conecction.
  • Two buttons for download and delete the indexed database were added on the Symbols section. NOTE: The idb will not be deleted, just cleared.
  • Improve the error handlers. This will prevent if exist an error while downloading the package or while processing.
  • A signal controller was added on the arasaac file request, to avoid memory leaks if the user goes back while the download is active.

close #1529

@RodriSanchez1 RodriSanchez1 marked this pull request as ready for review July 12, 2023 20:57
@RodriSanchez1 RodriSanchez1 requested a review from tomivm July 18, 2023 20:01
src/components/Settings/Symbols/Symbols.messages.js Outdated Show resolved Hide resolved
src/components/Settings/Symbols/Symbols.messages.js Outdated Show resolved Hide resolved
const options = {
signal: controller.signal,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is well implemented, anyway I don't see it is working. I just turn off the connection during the download but nothing happens.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works when you go back to the last history page while downloading. Without this implementation you will see a memory leak error.

src/components/Settings/Symbols/Symbols.component.js Outdated Show resolved Hide resolved
src/components/Settings/Symbols/Symbols.component.js Outdated Show resolved Hide resolved
@martinbedouret martinbedouret merged commit 62accf0 into cboard-org:master Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slide switch enabled after cancel download Arasaac symbols
3 participants