Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/capture premium features #1353

Merged
merged 15 commits into from
Feb 22, 2023
Merged

Feature/capture premium features #1353

merged 15 commits into from
Feb 22, 2023

Conversation

tomivm
Copy link
Collaborator

@tomivm tomivm commented Feb 10, 2023

close #1351

@tomivm tomivm added the premiun label Feb 10, 2023
@RodriSanchez1
Copy link
Collaborator

RodriSanchez1 commented Feb 15, 2023 •
edited
Loading

  • For share board we can do same than the share button on nav bar. That show the share modal, and when you try to share, the feature blocked modal shows up.
  • When a online language is selected, a online voice is seted. This avoid the premium modal and breaks the functionality of capture premium feature. I think we can separate the managment of the online voices in other PR

@tomivm
Copy link
Collaborator Author

tomivm commented Feb 16, 2023 •
edited
Loading

Good review!
During the change language from language setting, The app is remounted and the premiumRequiredModal is positioned behind the settings full-screen dialog.

@RodriSanchez1 RodriSanchez1 merged commit 0da72d0 into cboard-org:android-app-purchase Feb 22, 2023
@RodriSanchez1 RodriSanchez1 linked an issue Feb 22, 2023 that may be closed by this pull request
Capture the premium features #1351
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RodriSanchez1 RodriSanchez1 RodriSanchez1 approved these changes

@martinbedouret martinbedouret Awaiting requested review from martinbedouret

Assignees
No one assigned
Labels
premiun
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Capture the premium features
2 participants
@tomivm @RodriSanchez1