Add comment and tag #19
Conversation
test/corpus/comments_and_notes.txt
Outdated
| (quantity))) | ||
| (posting | ||
| (account)) | ||
| (note))))) |
There was a problem hiding this comment.
This should be (note (tag) (tag) (tag)) but not sure why tags aren't detected.
There was a problem hiding this comment.
It looks like this grammar takes manual control of whitespace by setting extras: ($) => []. Extras defaults to whitespace and controls what tokens may appear anywhere in the grammar without needing to write them explicitly. With it disabled, you may need to add optional($.whitespace) in places where whitespace is valid
|
The part about the comments looks fine to me, but I don't want to add tags until they work properly, so I recommend that you remove that from the PR. Feel free to open another PR for tags if you get them working. I briefly looked at tags about a year ago and concluded that they required an external C/C++ scanner, at least to support the whole grammar. I can't remember why exactly, and maybe it was just me missing something 🤷 |
Not sure why tags aren't working.
Also, if you want can add me or @the-mikedavis (I put his name since he is quite familiar with tree-sitter but not because he use ledger) in as maintainer, in case you are not active someone can still merge pull requests since we use it for https://github.com/helix-editor/helix