Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloadable table rownames #7

Merged
merged 6 commits into from
Aug 8, 2019
Merged

Downloadable table rownames #7

merged 6 commits into from
Aug 8, 2019

Conversation

ginberg
Copy link

@ginberg ginberg commented Aug 8, 2019

  • downloadableTable: add support for displaying rownames if these are set, otherwise display row_ids

@codecov-io
Copy link

codecov-io commented Aug 8, 2019

Codecov Report

Merging #7 into cran will increase coverage by 2.22%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             cran       #7      +/-   ##
==========================================
+ Coverage   61.88%   64.11%   +2.22%     
==========================================
  Files           9        9              
  Lines         732      652      -80     
==========================================
- Hits          453      418      -35     
+ Misses        279      234      -45
Impacted Files Coverage Δ
R/downloadableTable.R 28.98% <0%> (-0.6%) ⬇️
R/fw_helpers_external.R 92.72% <0%> (-0.83%) ⬇️
R/fw_helpers_internal.R 98.43% <0%> (-0.28%) ⬇️
R/appReset.R 26.22% <0%> (+1.98%) ⬆️
R/bodyFooter.R 39.13% <0%> (+3.13%) ⬆️
R/downloadablePlot.R 67.24% <0%> (+5.33%) ⬆️
R/downloadFile.R 31.25% <0%> (+5.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9c3e52...5c54b3a. Read the comment docs.

Copy link
Owner

@cb4ds cb4ds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also update the most-minor version number

@ginberg
Copy link
Author

ginberg commented Aug 8, 2019

ok, I have updated the version number. Should I also update the NEWS.md?

@cb4ds
Copy link
Owner

cb4ds commented Aug 8, 2019

I'll do that when I go to push to CRAN, but thanks!

@cb4ds cb4ds merged commit 2672468 into cb4ds:cran Aug 8, 2019
cb4ds added a commit that referenced this pull request Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants