downloadableTable selection of rows #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge remote-tracking branch 'upstream/cran' into cran # Conflicts: # DESCRIPTION
Codecov Report
@@ Coverage Diff @@
## cran #14 +/- ##
==========================================
- Coverage 63.52% 62.85% -0.67%
==========================================
Files 9 9
Lines 658 665 +7
==========================================
Hits 418 418
- Misses 240 247 +7
Continue to review full report at Codecov.
|
cb4ds
requested changes
Nov 8, 2019
R/downloadableTable.R
Outdated
| @@ -118,7 +120,7 @@ downloadableTableUI <- function(id, | |||
| #' server.R using the same id provided in \code{downloadableTableUI}: | |||
| #' | |||
| #' \strong{\code{callModule(downloadableTable, id, logger, filenameroot, | |||
| #' downloaddatafxns, tabledata, rownames, caption)}} | |||
| #' downloaddatafxns, tabledata, selection, rownames, caption)}} | |||
There was a problem hiding this comment.
need to move this to the end of the function for backwards compatibility for users who do not use named inputs.
|
Is it possible to also add a test? Thanks! |
add manual test to check selection of rows in downloadableTable module
|
ok, I have moved the selection so that it's the last argument. What do you think of a manual test where we start the module in a shiny app and the tester has to check if the selection is set? See the test file that I added. I don't know how we can test it otherwise. |
cb4ds
approved these changes
Nov 11, 2019
cb4ds
added a commit
that referenced
this pull request
Dec 10, 2019
* downloadFile xlsx rownames (#11) * remove httr import * downloadable table: add support for displaying rownames * simplify * remove column name for rownames column * update version number * add option to add rownames to downloadable xlsx file * fix item not found * refactor * downloadableTable selection of rows (#14) * remove httr import * downloadable table: add support for displaying rownames * simplify * remove column name for rownames column * update version number * add option to add rownames to downloadable xlsx file * fix item not found * refactor * add selection parameter * doc * force update if the same selection is provided * simplify * move selection argument for backwards compatibility add manual test to check selection of rows in downloadableTable module * remove manual test * fix single select (#15) * fix single select * shinydashboardPlus integration (#13) * remove httr import * downloadable table: add support for displaying rownames * simplify * remove column name for rownames column * update version number * add option to add rownames to downloadable xlsx file * fix item not found * refactor * initial shinydashboardplus integration * fix layout * dynamic right sidebar * update * updates * replace table by fluidRow * styling * update example * add documentation * revert fix * update documentation, add right sidebar content * update example * process review comment * add reset button argument update right sidebar functionality * update documentation/formatting * rename right_sidebar to rightsidebar * rename * rename reset to resetbutton * documentation * fix single select * documentation/formatting updates * undo 7dca316 * releasing 0.4.7 to CRAN
cb4ds
added a commit
that referenced
this pull request
Jul 3, 2020
* Check reactive class value using `shiny::is.reactive()` (#25) * Check reactive class value using `inherits` * Use `shiny::is.reactive()` instead of `inherits()` * Accepted by CRAN (#26) * CRAN release 0.4.10-1 (#28) Co-authored-by: Barret Schloerke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Add ability to set selected rows in downloadableTable