EM-1570: Product Feature Modal (ESB) #119
Conversation
…or updated modal close button
| @@ -31,3 +31,16 @@ | |||
| text-decoration: none; | |||
| } | |||
| } | |||
|
|
|||
| @mixin close-x-overflow { | |||
| width: 25px; | |||
There was a problem hiding this comment.
should these values be $feature-modal-controls-size? (only if they're meant to be the same size rather than they just happen to be the same size)
There was a problem hiding this comment.
I'm going to create another variable for this. The two are unrelated however despite being the same size.
| width: 25px; | ||
| height: 25px; | ||
| border-radius: 50%; | ||
| background-color: #333; |
| color: white; | ||
| line-height: 0; | ||
| font-size: 16px; | ||
| right: -10px; |
There was a problem hiding this comment.
looking at the redlines doc, does the corner meet right in the middle of the circle? (i'm not entirely sure, you probably reviewed this with Susan before she left) If that's the case and if you use a variable for the height and width of the circle, you could use -$feature-modal-controls-size / 2 here
| @@ -61,12 +61,18 @@ $search__thumbnail-height: 5.3125rem; // 85px | |||
| $sitemap-angle-icon: 17px; | |||
| $social-media-icons: 19.2px; | |||
| $toggle-switch-width: 65px; | |||
| $visual-divider-endpoint-size: 13px; | |||
| $visual-divider-endpoint-size: 13px; | |||
There was a problem hiding this comment.
there was an extra space added at the end here
…f the close button for the prod modal, updating some colors
|
@arelia Feedback has been addressed, this PR is ready for your review again. |
Purpose:
This PR does the following:
Visit the link for more information about the modal:
https://github.com/cbdr/employer/pull/949