EM-1288: Search Page Styles #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrfantasticwonders
approved these changes
Jul 13, 2017
toastercup
approved these changes
Jul 13, 2017
arelia
force-pushed
the
topic/EM-1288-search-styles
branch
from
8ccc4b5 to
0d3a0b8
Compare
toastercup
approved these changes
Jul 17, 2017
arelia
force-pushed
the
topic/EM-1288-search-styles
branch
from
dd459fb to
1422aee
Compare
before and after edges (although ultimately not using a psuedo element to fix; instead, turning off border and border-radius completely before adding bottom border): https://screencast.com/t/t9ZWrkqm6o fix for slight movement when border gets added: https://codepen.io/arelia/pen/zzyoVw?editors=0100 and https://stackoverflow.com/questions/9612758/add-a-css-border-on-hover-without-moving-the-element
just keeping style that are specific to the component, not where it gets placed
arelia
force-pushed
the
topic/EM-1288-search-styles
branch
from
bfcc234 to
4800336
Compare
toastercup
approved these changes
Jul 21, 2017
There was a problem hiding this comment.
Great job with the text button fixes - that @supports is neat, too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://cb-content-enablement.atlassian.net/browse/EM-1288
Employer PR: https://github.com/cbdr/employer/pull/930
:hover:active:focusoutlinecursor: pointerto link stylesautocomplete-dropdownmixin (which won't break anything (buy boxes) b/c there's a default value for the param)