Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EM-1306 and EM-1309: Header Large with Background Image and with Side Image #111

Merged
merged 5 commits into from
Jun 30, 2017
Merged

EM-1306 and EM-1309: Header Large with Background Image and with Side Image #111

merged 5 commits into from
Jun 30, 2017

Conversation

arelia
Copy link
Contributor

@arelia arelia commented Jun 29, 2017 •
edited
Loading

Purpose:

EM-1309: As a designer or a front end developer, I'd like the pages that use the "header_large" header partial to henceforth use the "header_large_solutions" partial (renaming the partial) so that going forward we have:
EM-1306: As a designer or a front end developer, I'd like the product page headers to henceforth be known as "header_large" so that going forward we have

  • a defined set of headers
  • the same language for this header type
  • generic, reusable components when we want to use this header type again
  • I feel like this is an intermediate step between consolidating existing headers and making header large side and header large background the same thing. Right now these are two separate things per the stories, and they have significant differences in how the gradient backgrounds are added, but I think eventually they might be the same thing
    • But the side-image header was more different than I expected from the background image header, so maybe they won't be consolidated
  • Includes EM-1306 which was already done and just had partial/mixin/class name changes
  • EM-1309 mentions changes to the https://hiring.careerbuilder.com/recruiting-solutions/job-posting-and-candidate-profile-trends page, but that page was listed in the wrong place, no changes to it in this PR (it would be updated in https://github.com/cbdr/employer/pull/898)

JIRA:
https://cb-content-enablement.atlassian.net/browse/EM-1306
https://cb-content-enablement.atlassian.net/browse/EM-1309

Changes:

  • Changes to setup, Architectural changes, Migrations, Side effects
    *

  • Library changes

    • style base updates

Screenshots

  • Before
    image

  • After
    image

QA Links:
http://d774a5d6.ngrok.io

How to Verify These Changes

Relevant PRs/Dependencies:
https://github.com/cbdr/employer/pull/902

Additional Information

@arelia arelia self-assigned this Jun 29, 2017
@arelia arelia merged commit acadd82 into master Jun 30, 2017
@arelia arelia deleted the topic/EM-1306-EM-1309-header-large branch June 30, 2017 03:07
toastercup added a commit that referenced this pull request Jul 14, 2017
@toastercup
Revert "Merge pull request #111 from cb-talent-development/topic/EM-1…
b8ad621 
…306-EM-1309-header-large"

This reverts commit acadd82, reversing
changes made to 9fcc41e.
toastercup added a commit that referenced this pull request Jul 14, 2017
@toastercup
Revert "Merge pull request #111 from cb-talent-development/topic/EM-1…
93a83b1 
…306-EM-1309-header-large"
toastercup added a commit that referenced this pull request Jul 14, 2017
@toastercup
Revert "Revert "Merge pull request #111 from cb-talent-development/to…
d2eab04 
…pic/EM-1306-EM-1309-header-large""

This reverts commit 93a83b1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MKwenhua MKwenhua MKwenhua approved these changes

@toastercup toastercup toastercup approved these changes

@mrfantasticwonders mrfantasticwonders Awaiting requested review from mrfantasticwonders

Assignees

@arelia arelia

Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arelia @toastercup @MKwenhua