Skip to content

Commit

Permalink
feat: change reference for font-size
Browse files Browse the repository at this point in the history
  • Loading branch information
@ElliottAYoung
ElliottAYoung committed Feb 27, 2017
1 parent b24e3f7 commit 7b6aa29
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion sass/directives/_tooltips.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

.tooltip-contents {
display: none;
font-size: $tooltip-contents-font-size;
}

&:hover .tooltip-contents,
Expand All @@ -30,7 +31,6 @@
box-shadow: $base-box-shadow;
border: 0;
color: $grey-darker;
font-size: $tooltip-contents-font-size;
font-weight: $font-weight-normal;

&:before {
Expand Down
2 changes: 1 addition & 1 deletion sass/variables/_sizing.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ $hero-text-size: $h2-font-size;
$small-font-size: 13px;
$subhead-font-size: $base-font-size * 1.5;
$caption-font-size: $small-font-size;
$tooltip-contents-font-size: $base-font-size * 0.6875;
$tooltip-contents-font-size: 11px;

// Line height
$base-line-height: 1.5;
Expand Down

1 comment on commit 7b6aa29

@arelia
Copy link
Contributor

@arelia arelia commented on 7b6aa29 Feb 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ElliottAYoung Why these changes? And were they associated with a PR?

Using pixels means the font size won't scale and I think it makes more sense for the tooltip styling that you see to belong under the selector that determines when you see the tooltip

Please sign in to comment.