Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply style for columns without defining cells #317

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Apply style for columns without defining cells #317

merged 1 commit into from
Dec 13, 2023

Conversation

kiskoza
Copy link
Member

@kiskoza kiskoza commented Nov 21, 2023 •
edited
Loading

Description

Closes #159 . I've updated the column_styles example to show how it should work.

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • I added an entry to the changelog.

@kiskoza kiskoza force-pushed the add-style-for-column branch from d8d7f15 to 554fe1f Compare November 29, 2023 08:29
straydogstudio
straydogstudio approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@straydogstudio straydogstudio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest explicitly stating which row you are adding the green style to in the example. Other than that it looks good to me. I think it is column D (four):

https://github.com/caxlsx/caxlsx/pull/317/files#diff-4df760991eb4a4539eda70c005b5882a619197f0d1820d926e9317611f883898R22

@kiskoza kiskoza force-pushed the add-style-for-column branch from 554fe1f to fd0c690 Compare December 13, 2023 11:41
@kiskoza
Copy link
Member Author

kiskoza commented Dec 13, 2023

Thanks, I added the column letters to the comment

@kiskoza kiskoza merged commit b773825 into master Dec 13, 2023
@kiskoza kiskoza mentioned this pull request Feb 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straydogstudio straydogstudio straydogstudio approved these changes

@noniq noniq Awaiting requested review from noniq

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add style to all cells in the column
2 participants
@kiskoza @straydogstudio