style: simplify assignments using assignment operators

catenacyber · Jan 8, 2024 · fae648a · fae648a
1 parent c553de9
commit fae648a
Showing 1 changed file with 13 additions and 13 deletions.
diff --git a/analyzer/analyzer.go b/analyzer/analyzer.go
@@ -159,7 +159,7 @@ func (n *perfSprint) run(pass *analysis.Pass) (interface{}, error) {
 			if !ok {
 				neededPackages[fname] = make(map[string]bool)
 			}
-			removedFmtUsages[fname] = removedFmtUsages[fname] + 1
+			removedFmtUsages[fname]++
 			if fn == "fmt.Errorf" {
 				neededPackages[fname]["errors"] = true
 				d = &analysis.Diagnostic{
@@ -199,7 +199,7 @@ func (n *perfSprint) run(pass *analysis.Pass) (interface{}, error) {
 			// fmt.Sprint(nil) does not panic like nil.Error() does
 			errMethodCall := formatNode(pass.Fset, value) + ".Error()"
 			fname := pass.Fset.File(call.Pos()).Name()
-			removedFmtUsages[fname] = removedFmtUsages[fname] + 1
+			removedFmtUsages[fname]++
 			d = &analysis.Diagnostic{
 				Pos:     call.Pos(),
 				End:     call.End(),
@@ -218,7 +218,7 @@ func (n *perfSprint) run(pass *analysis.Pass) (interface{}, error) {
 
 		case isBasicType(valueType, types.Bool) && oneOf(verb, "%v", "%t"):
 			fname := pass.Fset.File(call.Pos()).Name()
-			removedFmtUsages[fname] = removedFmtUsages[fname] + 1
+			removedFmtUsages[fname]++
 			_, ok := neededPackages[fname]
 			if !ok {
 				neededPackages[fname] = make(map[string]bool)
@@ -247,7 +247,7 @@ func (n *perfSprint) run(pass *analysis.Pass) (interface{}, error) {
 			}
 
 			fname := pass.Fset.File(call.Pos()).Name()
-			removedFmtUsages[fname] = removedFmtUsages[fname] + 1
+			removedFmtUsages[fname]++
 			_, ok := neededPackages[fname]
 			if !ok {
 				neededPackages[fname] = make(map[string]bool)
@@ -277,7 +277,7 @@ func (n *perfSprint) run(pass *analysis.Pass) (interface{}, error) {
 			}
 		case isSlice && isBasicType(s.Elem(), types.Uint8) && oneOf(verb, "%x"):
 			fname := pass.Fset.File(call.Pos()).Name()
-			removedFmtUsages[fname] = removedFmtUsages[fname] + 1
+			removedFmtUsages[fname]++
 			_, ok := neededPackages[fname]
 			if !ok {
 				neededPackages[fname] = make(map[string]bool)
@@ -301,7 +301,7 @@ func (n *perfSprint) run(pass *analysis.Pass) (interface{}, error) {
 
 		case isBasicType(valueType, types.Int8, types.Int16, types.Int32) && oneOf(verb, "%v", "%d") && n.intConv:
 			fname := pass.Fset.File(call.Pos()).Name()
-			removedFmtUsages[fname] = removedFmtUsages[fname] + 1
+			removedFmtUsages[fname]++
 			_, ok := neededPackages[fname]
 			if !ok {
 				neededPackages[fname] = make(map[string]bool)
@@ -331,7 +331,7 @@ func (n *perfSprint) run(pass *analysis.Pass) (interface{}, error) {
 			}
 		case isBasicType(valueType, types.Int) && oneOf(verb, "%v", "%d"):
 			fname := pass.Fset.File(call.Pos()).Name()
-			removedFmtUsages[fname] = removedFmtUsages[fname] + 1
+			removedFmtUsages[fname]++
 			_, ok := neededPackages[fname]
 			if !ok {
 				neededPackages[fname] = make(map[string]bool)
@@ -354,7 +354,7 @@ func (n *perfSprint) run(pass *analysis.Pass) (interface{}, error) {
 			}
 		case isBasicType(valueType, types.Int64) && oneOf(verb, "%v", "%d"):
 			fname := pass.Fset.File(call.Pos()).Name()
-			removedFmtUsages[fname] = removedFmtUsages[fname] + 1
+			removedFmtUsages[fname]++
 			_, ok := neededPackages[fname]
 			if !ok {
 				neededPackages[fname] = make(map[string]bool)
@@ -389,7 +389,7 @@ func (n *perfSprint) run(pass *analysis.Pass) (interface{}, error) {
 				base = []byte("), 16")
 			}
 			fname := pass.Fset.File(call.Pos()).Name()
-			removedFmtUsages[fname] = removedFmtUsages[fname] + 1
+			removedFmtUsages[fname]++
 			_, ok := neededPackages[fname]
 			if !ok {
 				neededPackages[fname] = make(map[string]bool)
@@ -423,7 +423,7 @@ func (n *perfSprint) run(pass *analysis.Pass) (interface{}, error) {
 				base = []byte(", 16")
 			}
 			fname := pass.Fset.File(call.Pos()).Name()
-			removedFmtUsages[fname] = removedFmtUsages[fname] + 1
+			removedFmtUsages[fname]++
 			_, ok := neededPackages[fname]
 			if !ok {
 				neededPackages[fname] = make(map[string]bool)
@@ -463,7 +463,7 @@ func (n *perfSprint) run(pass *analysis.Pass) (interface{}, error) {
 				fix = formatNode(pass.Fset, value) + "+" + strconv.Quote(verb[5:])
 			}
 			fname := pass.Fset.File(call.Pos()).Name()
-			removedFmtUsages[fname] = removedFmtUsages[fname] + 1
+			removedFmtUsages[fname]++
 			d = &analysis.Diagnostic{
 				Pos:     call.Pos(),
 				End:     call.End(),
@@ -500,7 +500,7 @@ func (n *perfSprint) run(pass *analysis.Pass) (interface{}, error) {
 						pkgname, ok := pass.TypesInfo.ObjectOf(selecok).(*types.PkgName)
 						if ok && pkgname.Name() == pkg.Name() {
 							fname := pass.Fset.File(pkgname.Pos()).Name()
-							removedFmtUsages[fname] = removedFmtUsages[fname] - 1
+							removedFmtUsages[fname]--
 						}
 					}
 				})
@@ -531,7 +531,7 @@ func (n *perfSprint) run(pass *analysis.Pass) (interface{}, error) {
 				fix := ""
 				fname := pass.Fset.File(gd.Pos()).Name()
 				if removedFmtUsages[fname] < 0 {
-					fix = fix + `"fmt"`
+					fix += `"fmt"`
 					if len(neededPackages[fname]) == 0 {
 						return
 					}